Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CollectionView to support anchoring an item #623

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Update CollectionView to support anchoring an item #623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ jobs:
- uses: actions/checkout@v2

- name: Setting up Xcode
run: sudo xcode-select -s "/Applications/Xcode_14.3.app"
run: sudo xcode-select -s "/Applications/Xcode_15.1.app"

- name: Run tests
run: set -o pipefail && xcrun xcodebuild build test -scheme QuranEngine-Package -sdk "iphonesimulator" -destination "name=iPhone 14 Pro,OS=16.4" | xcpretty
run: set -o pipefail && xcrun xcodebuild build test -scheme QuranEngine-Package -sdk "iphonesimulator" -destination "name=iPhone 14 Pro,OS=17.2" | xcpretty

- uses: codecov/codecov-action@v3
with:
Expand All @@ -30,7 +30,7 @@ jobs:
- uses: actions/checkout@v2

- name: Setting up Xcode
run: sudo xcode-select -s "/Applications/Xcode_14.3.app"
run: sudo xcode-select -s "/Applications/Xcode_15.1.app"

- name: Build
run: set -o pipefail && xcrun xcodebuild build -workspace Example/QuranEngineApp.xcworkspace -scheme QuranEngineApp -sdk "iphonesimulator" -destination 'generic/platform=iOS' CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO | xcpretty
8 changes: 4 additions & 4 deletions ...s/__Snapshots__/QuranAudioPlayerTests/testPlayingDownloadedGaplessReciter1FullSura.1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,23 +15,23 @@
},
{
"endTime" : null,
"startTime" : 17.731999999999999
"startTime" : 17.732
},
{
"endTime" : null,
"startTime" : 22.329999999999998
"startTime" : 22.33
},
{
"endTime" : null,
"startTime" : 26.881
},
{
"endTime" : null,
"startTime" : 33.567999999999998
"startTime" : 33.568
},
{
"endTime" : null,
"startTime" : 39.009999999999998
"startTime" : 39.01
}
],
"url" : "\/audio_files\/mishari_alafasy\/001.mp3"
Expand Down
6 changes: 3 additions & 3 deletions ...napshots__/QuranAudioPlayerTests/testPlayingDownloadedGaplessReciter1SuraEndsEarly.1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"playing" : {
"_0" : {
"endTime" : 33.567999999999998,
"endTime" : 33.568,
"files" : [
{
"frames" : [
Expand All @@ -11,11 +11,11 @@
},
{
"endTime" : null,
"startTime" : 17.731999999999999
"startTime" : 17.732
},
{
"endTime" : null,
"startTime" : 22.329999999999998
"startTime" : 22.33
},
{
"endTime" : null,
Expand Down
2 changes: 1 addition & 1 deletion ...s__/QuranAudioPlayerTests/testPlayingDownloadedGaplessReciter1SurasHasEndTimestamp.1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
{
"endTime" : 284.899,
"startTime" : 275.88099999999997
"startTime" : 275.881
}
],
"url" : "\/audio_files\/mishari_alafasy\/077.mp3"
Expand Down
2 changes: 1 addition & 1 deletion ...oPlayerTests/testPlayingDownloadedGaplessReciter1SurasHasEndTimestampStopBeforeEnd.1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"playing" : {
"_0" : {
"endTime" : 275.88099999999997,
"endTime" : 275.881,
"files" : [
{
"frames" : [
Expand Down
8 changes: 4 additions & 4 deletions ...anAudioPlayerTests/testPlayingDownloadedGaplessReciter2Suras1stSuraHasEndTimestamp.1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"playing" : {
"_0" : {
"endTime" : 33.093000000000004,
"endTime" : 33.093,
"files" : [
{
"frames" : [
Expand All @@ -11,7 +11,7 @@
},
{
"endTime" : 284.899,
"startTime" : 275.88099999999997
"startTime" : 275.881
}
],
"url" : "\/audio_files\/mishari_alafasy\/077.mp3"
Expand All @@ -24,11 +24,11 @@
},
{
"endTime" : null,
"startTime" : 21.518999999999998
"startTime" : 21.519
},
{
"endTime" : null,
"startTime" : 27.111999999999998
"startTime" : 27.112
}
],
"url" : "\/audio_files\/mishari_alafasy\/078.mp3"
Expand Down
16 changes: 8 additions & 8 deletions ...s/__Snapshots__/QuranAudioPlayerTests/testPlayingDownloadedGaplessReciter3FullSura.1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@
},
{
"endTime" : null,
"startTime" : 10.034000000000001
"startTime" : 10.034
},
{
"endTime" : null,
"startTime" : 12.680999999999999
"startTime" : 12.681
},
{
"endTime" : null,
Expand All @@ -32,15 +32,15 @@
},
{
"endTime" : null,
"startTime" : 10.805999999999999
"startTime" : 10.806
},
{
"endTime" : null,
"startTime" : 14.606999999999999
"startTime" : 14.607
},
{
"endTime" : null,
"startTime" : 19.893999999999998
"startTime" : 19.894
},
{
"endTime" : null,
Expand All @@ -61,19 +61,19 @@
},
{
"endTime" : null,
"startTime" : 18.951000000000001
"startTime" : 18.951
},
{
"endTime" : null,
"startTime" : 24.57
},
{
"endTime" : null,
"startTime" : 32.968000000000004
"startTime" : 32.968
},
{
"endTime" : null,
"startTime" : 41.412999999999997
"startTime" : 41.413
}
],
"url" : "\/audio_files\/mishari_alafasy\/114.mp3"
Expand Down
1 change: 1 addition & 0 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ private func uiTargets() -> [[Target]] {
target(type, name: "ViewConstrainer", hasTests: false),
target(type, name: "UIx", hasTests: false, dependencies: [
"ViewConstrainer",
"VLogging",
]),
target(type, name: "NoorFont", hasTests: false, resources: [
.process("Resources"),
Expand Down
Loading
Loading