Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert PageController to SwiftUI #613

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Convert PageController to SwiftUI #613

merged 1 commit into from
Dec 26, 2023

Conversation

mohamede1945
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

Attention: 486 lines in your changes are missing coverage. Please review.

Comparison is base (4ac7338) 41.69% compared to head (8d210c1) 41.68%.

Files Patch % Lines
UI/NoorUI/Pager/PageViewController.swift 0.00% 152 Missing ⚠️
...atures/QuranPagesFeature/QuranPaginationView.swift 0.00% 113 Missing ⚠️
UI/NoorUI/Pager/QuranPageSeparators.swift 0.00% 70 Missing ⚠️
...es/QuranContentFeature/ContentViewController.swift 0.00% 57 Missing ⚠️
...eatures/QuranContentFeature/ContentViewModel.swift 0.00% 38 Missing ⚠️
.../SwiftUI/Miscellaneous/DisableSafeAreaInsets.swift 0.00% 31 Missing ⚠️
Features/QuranViewFeature/QuranInteractor.swift 0.00% 11 Missing ⚠️
...ftUI/Views/StaticViewControllerRepresentable.swift 0.00% 5 Missing ⚠️
...atures/QuranImageFeature/ContentImageBuilder.swift 0.00% 4 Missing ⚠️
...TranslationFeature/ContentTranslationBuilder.swift 0.00% 4 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #613      +/-   ##
==========================================
- Coverage   41.69%   41.68%   -0.02%     
==========================================
  Files         506      505       -1     
  Lines       19646    19652       +6     
==========================================
  Hits         8192     8192              
- Misses      11454    11460       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohamede1945 mohamede1945 merged commit 85dcc7a into main Dec 26, 2023
2 checks passed
@mohamede1945 mohamede1945 deleted the afifi branch December 26, 2023 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant