Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search bar disappearance on iOS 14 #603

Merged
merged 1 commit into from
Dec 10, 2023
Merged

Fix search bar disappearance on iOS 14 #603

merged 1 commit into from
Dec 10, 2023

Conversation

mohamede1945
Copy link
Collaborator

Apparently, UIHostingController takes over the responsibility of the navigationItem on iOS 14.

Copy link

codecov bot commented Dec 10, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (b504ab3) 42.14% compared to head (b4683ef) 42.13%.

Files Patch % Lines
Features/SearchFeature/SearchViewController.swift 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #603      +/-   ##
==========================================
- Coverage   42.14%   42.13%   -0.01%     
==========================================
  Files         500      500              
  Lines       19442    19445       +3     
==========================================
  Hits         8194     8194              
- Misses      11248    11251       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohamede1945 mohamede1945 merged commit 04f75d7 into main Dec 10, 2023
2 checks passed
@mohamede1945 mohamede1945 deleted the afifi branch December 10, 2023 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant