Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve search functionality #578

Merged
merged 1 commit into from
Nov 5, 2023
Merged

Improve search functionality #578

merged 1 commit into from
Nov 5, 2023

Conversation

mohamede1945
Copy link
Collaborator

  • Resolved issues with the search feature.
  • Implemented diacritic-insensitive searching.
  • Enhanced search to be insensitive to Unicode categories: Mark (M), Punctuation (P), Symbol (S), and Control (C), as well as the Arabic Tatweel character (U+0640).
  • Normalized search strings using Unicode Normalization Form KD.
  • Unified search and autocomplete behavior by adopting a consistent matching algorithm.

TODO:

  • Integrate Full-Text Search (FTS) for enhanced searching capabilities.
  • Extend search functionality to include all downloaded translations and tafseers.
  • Implement collapsible search results, allowing users to collapse specific results for easier navigation to subsequent entries.

- Resolved issues with the search feature.
- Implemented diacritic-insensitive searching.
- Enhanced search to be insensitive to Unicode categories: Mark (M), Punctuation (P), Symbol (S), and Control (C), as well as the Arabic Tatweel character (U+0640).
- Normalized search strings using Unicode Normalization Form KD.
- Unified search and autocomplete behavior by adopting a consistent matching algorithm.

TODO:
- Integrate Full-Text Search (FTS) for enhanced searching capabilities.
- Extend search functionality to include all downloaded translations and tafseers.
- Implement collapsible search results, allowing users to collapse specific results for easier navigation to subsequent entries.
Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (79fa74e) 41.16% compared to head (dcfadbc) 41.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #578      +/-   ##
==========================================
- Coverage   41.16%   41.16%   -0.01%     
==========================================
  Files         495      494       -1     
  Lines       19019    19017       -2     
==========================================
- Hits         7830     7828       -2     
  Misses      11189    11189              
Files Coverage Δ
...tKit/Sources/Search/Searchers/NumberSearcher.swift 96.92% <100.00%> (+2.63%) ⬆️
...Sources/Search/Searchers/PersistenceSearcher.swift 92.30% <100.00%> (+18.97%) ⬆️
...extKit/Sources/Search/Searchers/SuraSearcher.swift 100.00% <100.00%> (ø)
...Sources/Search/Searchers/TranslationSearcher.swift 100.00% <100.00%> (ø)
...in/QuranTextKit/Tests/CompositeSearcherTests.swift 100.00% <100.00%> (ø)
Features/SearchFeature/SearchViewModel.swift 0.00% <0.00%> (ø)
...erseTextPersistence/GRDBVerseTextPersistence.swift 93.33% <60.00%> (+0.06%) ⬆️
...t/Sources/Search/Searchers/CompositeSearcher.swift 81.96% <86.66%> (-1.37%) ⬇️
...nTextKit/Sources/Search/Searchers/SearchTerm.swift 95.34% <95.34%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohamede1945 mohamede1945 merged commit a2a6965 into main Nov 5, 2023
2 checks passed
@mohamede1945 mohamede1945 deleted the afifi branch November 5, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant