Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix russian transliteration strings for surahs titles #558

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

aziev
Copy link
Contributor

@aziev aziev commented Aug 17, 2023

Titles for some surahs are incorrect in russian. This PR fixes them.

@mohamede1945
Copy link
Collaborator

Thank you for your contribution. However, I'm sourcing the translations from the Android repository. It would be best if you could make the fix there. Before the upcoming release, I'll import the updated translations.

Here's the file for your reference: sura_names.xml in the Android repo.

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4a8108f) 41.12% compared to head (c0d8c2a) 41.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #558   +/-   ##
=======================================
  Coverage   41.12%   41.13%           
=======================================
  Files         495      495           
  Lines       19026    19026           
=======================================
+ Hits         7825     7826    +1     
+ Misses      11201    11200    -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aziev
Copy link
Contributor Author

aziev commented Sep 1, 2023

@mohamede1945 it seems to be fixed in the android app.
جزاك الله خيرا

@mohamede1945
Copy link
Collaborator

Awesome! Jazak Allah Khairan for your help and verification, @aziev! I'll go ahead and merge this PR. That way, the next time I import translations, I can use your changes as a reference to ensure everything matches up. Thank

you!

@mohamede1945 mohamede1945 merged commit af9cbdc into quran:main Sep 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants