Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show advanced audio options button #556

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

zukhan
Copy link
Collaborator

@zukhan zukhan commented Aug 2, 2023

Currently, in order to change any of the advanced audio options, you first need to hit the play button. This change displays the advanced audio options button on the reciter bar so you can change the audio settings without hitting play first.

Before and After:

audio_options (before   after)

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #556 (a2347cf) into main (e550546) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #556      +/-   ##
==========================================
- Coverage   41.15%   41.12%   -0.03%     
==========================================
  Files         495      495              
  Lines       19011    19026      +15     
==========================================
+ Hits         7824     7825       +1     
- Misses      11187    11201      +14     
Files Changed Coverage Δ
...AudioBannerFeature/AudioBannerViewController.swift 0.00% <0.00%> (ø)
...ures/AudioBannerFeature/AudioBannerViewModel.swift 0.00% <0.00%> (ø)
...tures/AudioBannerFeature/AudioReciterBarView.swift 0.00% <ø> (ø)

... and 1 file with indirect coverage changes

@mohamede1945
Copy link
Collaborator

Looks awesome! Jazak Allah khyran.

@mohamede1945 mohamede1945 merged commit 0ce799e into main Aug 4, 2023
2 checks passed
@mohamede1945 mohamede1945 deleted the zukhan/show-audio-options branch August 4, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants