Remove duplicate Error.isCancelled (#611)

Core/Utilities/Sources/Extensions/Error+Extension.swift

@@ -0,0 +1,26 @@
+//
+//  Error+Extension.swift
+//
+//
+//  Created by Mohamed Afifi on 2023-12-19.
+//
+
+import Foundation
+
+extension Error {
+    public var isCancelled: Bool {
+        if self is CancellationError {
+            return true
+        }
+
+        do {
+            throw self
+        } catch URLError.cancelled {
+            return true
+        } catch CocoaError.userCancelled {
+            return true
+        } catch {
+            return false
+        }
+    }
+}

Data/BatchDownloader/Sources/Downloader/DownloadBatchResponse.swift

@@ -195,9 +195,7 @@ public actor DownloadBatchResponse {
         }
 
         if let error = firstError {
-            if !(error is CancellationError) {
-                crasher.recordError(error, reason: "Download failed \(batchId)")
-            }
+            crasher.recordError(error, reason: "Download failed \(batchId)")
 
             // Cancel other tasks if any has failed
             for request in requests {

Data/BatchDownloader/Sources/Downloader/DownloadSessionDelegate.swift

@@ -176,10 +176,6 @@ private extension Error {
         (self as NSError).userInfo[NSURLSessionDownloadTaskResumeData] as? Data
     }
 
-    var isCancelled: Bool {
-        (self as? URLError)?.code == URLError.cancelled
-    }
-
     func removeResumeData() -> Error {
         let error = self as NSError
         guard error.userInfo[NSURLSessionDownloadTaskResumeData] != nil else {

Domain/ReadingService/Sources/ReadingResourcesService.swift

@@ -126,9 +126,7 @@ public actor ReadingResourcesService {
 
             return .ready
         } catch {
-            if !(error is CancellationError) {
-                crasher.recordError(error, reason: "Failed to download \(reading). Error: \(error)")
-            }
+            crasher.recordError(error, reason: "Failed to download \(reading). Error: \(error)")
             return .error(error as NSError)
         }
     }

UI/NoorUI/BaseControllers/UIViewController+Error.swift

@@ -51,21 +51,3 @@ extension Error {
         return description ?? l("error.message.general")
     }
 }
-
-extension Error {
-    var isCancelled: Bool {
-        if self is CancellationError {
-            return true
-        }
-
-        do {
-            throw self
-        } catch URLError.cancelled {
-            return true
-        } catch CocoaError.userCancelled {
-            return true
-        } catch {
-            return false
-        }
-    }
-}