Delete local translation and insert a new one

As we cannot change the Id of the translation through UPDATE query.
quran · Nov 8, 2023 · 27329aa · 27329aa
1 parent 56d8864
commit 27329aa
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 9 deletions.
diff --git a/Domain/TranslationService/Sources/TranslationsRepository.swift b/Domain/TranslationService/Sources/TranslationsRepository.swift
@@ -71,11 +71,10 @@ public struct TranslationsRepository {
 
     private func saveCombined(translations: [Translation], localMap: [String: Translation]) async throws {
         for translation in translations {
-            if localMap[translation.fileName] != nil {
-                try await persistence.update(translation)
-            } else {
-                try await persistence.insert(translation)
+            if let oldTranslation = localMap[translation.fileName] {
+                try await persistence.remove(oldTranslation)
             }
+            try await persistence.insert(translation)
         }
     }
 }
diff --git a/Domain/TranslationService/Tests/TranslationsRepositoryTests.swift b/Domain/TranslationService/Tests/TranslationsRepositoryTests.swift
@@ -49,7 +49,7 @@ class TranslationsRepositoryTests: XCTestCase {
     func test_updatedVersion() async throws {
         let translation = translations[0]
         let updatedTranslation = Translation(
-            id: translation.id,
+            id: translation.id + 45,
             displayName: translation.displayName,
             translator: translation.translator,
             translatorForeign: translation.translatorForeign,
@@ -69,11 +69,10 @@ class TranslationsRepositoryTests: XCTestCase {
         XCTAssertEqual(localResults, [updatedTranslation])
     }
 
-    // TODO: This crashes the app, we should fix it.
-    func DISABLED_test_updatedFileName() async throws {
+    func test_updatedFileName() async throws {
         let translation = translations[0]
         let updatedTranslation = Translation(
-            id: translation.id,
+            id: translation.id + 19,
             displayName: translation.displayName,
             translator: translation.translator,
             translatorForeign: translation.translatorForeign,
@@ -90,7 +89,14 @@ class TranslationsRepositoryTests: XCTestCase {
         try await service.downloadAndSyncTranslations()
 
         let localResults = try await retriever.getLocalTranslations()
-        XCTAssertEqual(localResults, [updatedTranslation])
+
+        // Expected to create a duplicate entry if fileName changed,
+        // fileName should not change to upgrade, it's a unique value
+        // per translation
+        XCTAssertEqual(localResults.sorted(), [
+            expectedTranslation(translation, installedVersion: nil),
+            expectedTranslation(updatedTranslation, installedVersion: nil),
+        ].sorted())
     }
 
     // MARK: Private