Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QUOTIENT_API to Matrix API data definitions #701

Closed
wants to merge 3 commits into from

Conversation

KitsuneRal
Copy link
Member

Needed for #630.

@KitsuneRal KitsuneRal added the enhancement A feature or change request for the library label Aug 21, 2023
@vkrause
Copy link
Member

vkrause commented Aug 21, 2023

All of these structs seem to have only member variables and no (non-inline) member functions, right? If so, there are no symbols to export here, so this should not make any difference?

@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

42.9% 42.9% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@KitsuneRal
Copy link
Member Author

Uhm - @TobiasFella did you really need QUOTIENT_API in that CrossSigningKey definition in #630?

@TobiasFella
Copy link
Member

no, probably not - might just be a leftover from debugging, will try removing it now...

@KitsuneRal KitsuneRal closed this Aug 22, 2023
@KitsuneRal KitsuneRal added invalid There's nothing to improve in the library and removed enhancement A feature or change request for the library labels Aug 22, 2023
@KitsuneRal KitsuneRal deleted the kitsune/quotent_api-throughout-csapi branch September 11, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid There's nothing to improve in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants