Cleanup/tweaks/docs/etc. across the board #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiasFella
previously approved these changes
Aug 9, 2023
The previous log lines showed either inexistent (to-device event id) or duplicate and also user-unfriendly (numeric error code, although QOlm* classes already log each fault, with textual codes) data points.
Although queryOr() is a more versatile and sometimes more optimal (even if peculiar-looking) route to the same data, RoomStateView::content() is arguably more readable where it can be used (i.e. when the respective state event class has content() defined, and its content class can be default-constructed).
Copied from Quaternion's README.md. [skip ci]
KitsuneRal
force-pushed
the
kitsune/cleanup-in-0.8
branch
from
a20a347
to
4843edd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a collection of various kinds of minor quality-of-life changes.