Enable key backup API #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No semantic changes.
key_backup.yaml has a nasty repetition of the 'version' parameter within a single API call, with the comment saying that if the version replica in the request body is specified it should coincide with the version provided in the request path. By default, GTAD would diligently pull both replicas to the constructor argument list, producing incorrect C++ code. The line added to gtad.yaml here eliminates the replica in the request body (because '>' only applies to the request body - GTAD documentation covers that, although not quite explicitly).
|
Kudos, SonarCloud Quality Gate passed!
|
TobiasFella
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is merely housekeeping; the two others carry the substance.
#687 would need this.