Fix Sonar warnings

quotient-im · Sep 21, 2024 · 4f55444 · 4f55444
1 parent 7b3d2ba
commit 4f55444
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/Quotient/events/eventrelation.h b/Quotient/events/eventrelation.h
@@ -38,9 +38,12 @@ struct QUOTIENT_API EventRelation {
  {
  return { ReplacementType, std::move(eventId) };
  }
- static EventRelation replyInThread(QString threadRootId, bool isFallingBack, QString inThreadReplyEventId)
+ static EventRelation replyInThread(QString threadRootId, bool isFallingBack,
+ QString inThreadReplyEventId)
  {
- return { ThreadType, std::move(threadRootId), {}, std::move(isFallingBack), std::move(inThreadReplyEventId) };
+ return {
+ ThreadType, std::move(threadRootId), {}, isFallingBack, std::move(inThreadReplyEventId)
+ };
  }
 };
 

diff --git a/Quotient/events/roommessageevent.cpp b/Quotient/events/roommessageevent.cpp
@@ -237,8 +237,7 @@ bool RoomMessageEvent::isReply(bool includeFallbacks) const
 
 QString RoomMessageEvent::replyEventId(bool includeFallbacks) const
 {
- const auto relation = relatesTo();
- if (relation.has_value()) {
+ if (const auto relation = relatesTo()) {
  if (relation.value().type == EventRelation::ReplyType) {
  return relation.value().eventId;
  } else if (relation.value().type == EventRelation::ThreadType &&