Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from kubebuilder v4.0.0 to v4.1.0 #340

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Conversation

int128
Copy link
Member

@int128 int128 commented Nov 4, 2024

Copy link
Contributor

github-actions bot commented Nov 4, 2024

diff

  • config/default/apps_v1_deployment_google-cloud-pubsub-operator-controller-manager.yaml
  • config/default/rbac.authorization.k8s.io_v1_clusterrole_google-cloud-pubsub-operator-metrics-auth-role.yaml (New)
  • config/default/rbac.authorization.k8s.io_v1_clusterrole_google-cloud-pubsub-operator-metrics-reader.yaml (New)
  • config/default/rbac.authorization.k8s.io_v1_clusterrolebinding_google-cloud-pubsub-operator-metrics-auth-rolebinding.yaml (New)
  • config/default/v1_service_google-cloud-pubsub-operator-controller-manager-metrics-service.yaml (New)

config/default/apps_v1_deployment_google-cloud-pubsub-operator-controller-manager.yaml

--- a/tmp/kustomize-action-XXXXXX2BtOhw/config/default/apps_v1_deployment_google-cloud-pubsub-operator-controller-manager.yaml
+++ b/tmp/kustomize-action-XXXXXXvyz6Bt/config/default/apps_v1_deployment_google-cloud-pubsub-operator-controller-manager.yaml
@@ -21,6 +21,7 @@ spec:
     spec:
       containers:
       - args:
+        - --metrics-bind-address=:8443
         - --leader-elect
         - --health-probe-bind-address=:8081
         command:

config/default/rbac.authorization.k8s.io_v1_clusterrole_google-cloud-pubsub-operator-metrics-auth-role.yaml

--- /dev/null
+++ b/tmp/kustomize-action-XXXXXXvyz6Bt/config/default/rbac.authorization.k8s.io_v1_clusterrole_google-cloud-pubsub-operator-metrics-auth-role.yaml
@@ -0,0 +1,17 @@
+apiVersion: rbac.authorization.k8s.io/v1
+kind: ClusterRole
+metadata:
+  name: google-cloud-pubsub-operator-metrics-auth-role
+rules:
+- apiGroups:
+  - authentication.k8s.io
+  resources:
+  - tokenreviews
+  verbs:
+  - create
+- apiGroups:
+  - authorization.k8s.io
+  resources:
+  - subjectaccessreviews
+  verbs:
+  - create

config/default/rbac.authorization.k8s.io_v1_clusterrole_google-cloud-pubsub-operator-metrics-reader.yaml

--- /dev/null
+++ b/tmp/kustomize-action-XXXXXXvyz6Bt/config/default/rbac.authorization.k8s.io_v1_clusterrole_google-cloud-pubsub-operator-metrics-reader.yaml
@@ -0,0 +1,9 @@
+apiVersion: rbac.authorization.k8s.io/v1
+kind: ClusterRole
+metadata:
+  name: google-cloud-pubsub-operator-metrics-reader
+rules:
+- nonResourceURLs:
+  - /metrics
+  verbs:
+  - get

config/default/rbac.authorization.k8s.io_v1_clusterrolebinding_google-cloud-pubsub-operator-metrics-auth-rolebinding.yaml

--- /dev/null
+++ b/tmp/kustomize-action-XXXXXXvyz6Bt/config/default/rbac.authorization.k8s.io_v1_clusterrolebinding_google-cloud-pubsub-operator-metrics-auth-rolebinding.yaml
@@ -0,0 +1,12 @@
+apiVersion: rbac.authorization.k8s.io/v1
+kind: ClusterRoleBinding
+metadata:
+  name: google-cloud-pubsub-operator-metrics-auth-rolebinding
+roleRef:
+  apiGroup: rbac.authorization.k8s.io
+  kind: ClusterRole
+  name: google-cloud-pubsub-operator-metrics-auth-role
+subjects:
+- kind: ServiceAccount
+  name: google-cloud-pubsub-operator-controller-manager
+  namespace: google-cloud-pubsub-operator-system

config/default/v1_service_google-cloud-pubsub-operator-controller-manager-metrics-service.yaml

--- /dev/null
+++ b/tmp/kustomize-action-XXXXXXvyz6Bt/config/default/v1_service_google-cloud-pubsub-operator-controller-manager-metrics-service.yaml
@@ -0,0 +1,17 @@
+apiVersion: v1
+kind: Service
+metadata:
+  labels:
+    app.kubernetes.io/managed-by: kustomize
+    app.kubernetes.io/name: google-cloud-pubsub-operator
+    control-plane: controller-manager
+  name: google-cloud-pubsub-operator-controller-manager-metrics-service
+  namespace: google-cloud-pubsub-operator-system
+spec:
+  ports:
+  - name: https
+    port: 8443
+    protocol: TCP
+    targetPort: 8443
+  selector:
+    control-plane: controller-manager

See the workflow run

@int128 int128 closed this Nov 4, 2024
@int128 int128 reopened this Nov 4, 2024
@int128 int128 merged commit 5567032 into main Nov 4, 2024
6 checks passed
@int128 int128 deleted the upgrade-kubebuilder-v4.1.0 branch November 4, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant