Merge upstream 3.4.2 #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix compilation issues by importing UIKit (dev branch)
…odspec, update IBAV
iOS 14, XCode 12, Swift 5.3, goodbye iOS 11
Prepare release 3.4.0
…ssage Fix casting MessageType to custom type for LinkPreview cells
Remove keyboard observers in viewWillDisappear, not deinit
manicmaniac
commented
Aug 28, 2023
| ======= | ||
| PODFILE CHECKSUM: 24c39a08ead4a8771aa94310cfc35fe3be6b3105 | ||
| >>>>>>> 3.4.2 | ||
| PODFILE CHECKSUM: 31c6eb1d734807f78336ea60201a116e2410b2dd |
There was a problem hiding this comment.
This checksum was recalculated by bundle exec pod install
manicmaniac
commented
Aug 28, 2023
| @@ -29,7 +29,7 @@ internal extension MessageKind { | |||
| switch self { | |||
| case .linkPreview(let linkItem): | |||
| return linkItem.textKind | |||
| case .text, .emoji, .attributedText: | |||
| case .announcement, .text, .emoji, .attributedText: | |||
There was a problem hiding this comment.
.announcement was added by us.
manicmaniac
commented
Aug 28, 2023
| @@ -7,6 +7,7 @@ | |||
| // | |||
|
|
|||
| import Foundation | |||
| import UIKit | |||
There was a problem hiding this comment.
From some version of Swift Package Manager, packages are not be compiled without declaring the correct imported modules.
In this file UIFont, UIEdgeInsets and other UI-prefixed classes are used.
elliekwon
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
import UIKitat 304483d3a2ac0f and 304483d need to be reviewed.
Screenshot