forked from MessageKit/MessageKit
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge upstream 3.2.0 #22
Merged
+2,950
−629
Merged
Changes from all commits
Commits
Show all changes
199 commits
Select commit
Hold shift + click to select a range
454b3f6
Update changelog for development again
Kaspik fc9b0ce
Change example build to use cache for pods, without fetching specs
Kaspik 426dbde
Update pods cache
Kaspik 60e09a6
Update config and podspec
Kaspik 8567db0
Fix string char
Kaspik 5fb3079
Pre-start simulator for running tests
Kaspik 248e364
Fix config
Kaspik 97357c7
Add Github Actions config for Danger and Swiftlint running on PRs
Kaspik b6ca5cf
Fix syntax for run
Kaspik 12c23a8
Fix PR
Kaspik 5ba964b
Update config
Kaspik 387e3d7
Merge branch 'circleCIUpdates' into PR_danger_swiftlint
Kaspik 6f5e96e
Fix PR header
Kaspik 4b4dd27
Merge pull request #1256 from classdojo/circleCIUpdates
Kaspik 53cfda9
Fix Dangerfile
Kaspik 5a33741
Merge pull request #1257 from classdojo/PR_danger_swiftlint
Kaspik eff62f8
Remove deprecated file for swift version
Kaspik 16b4505
Merge branch 'fixAppVersion' into cleanupSwift
Kaspik b17f471
Merge branch 'master' into development
Kaspik ee7ebc5
Merge branch 'development' into cleanupSwift
Kaspik 7c66e23
Update Copyright date
Kaspik bc7ba72
Drop iOS 9 and iOS 10
Kaspik 26c38d5
Update example project
Kaspik c57db5f
Update changelog
Kaspik e20dcc4
Remove travis.ci file as this project uses Circle CI
Kaspik 9a492e9
Fix tests
Kaspik 46616a0
Update codecov code
Kaspik b0ab6f9
Fix badge for correct branch
Kaspik 7729b8c
Merge branch 'master' into development
Kaspik 369a6c1
Merge branch 'development' into cleanupSwift
Kaspik 1cc29a9
feat: SwiftLint in Example project
martinpucik ce54a3b
Revert "Update codecov code"
Kaspik 8d06c0c
feat: SwiftLint in Example project
martinpucik 27c42a4
feat: SwiftLint in Example project
martinpucik 1fd1aca
feat: SwiftLint in Example project
martinpucik 01c80a9
feat: SwiftLint in Example project
martinpucik dc17fb6
feat: SwiftLint in Example project
martinpucik 967cab0
feat: SwiftLint in Example project
martinpucik eb241f3
feat: SwiftLint in Example project
martinpucik b3c8d65
Switch to Github Actions, Update Danger
Kaspik 9237c50
Disable Example app cache until https://github.com/MessageKit/Message…
Kaspik 38b99a4
Merge pull request #1272 from martinpucik/swiftlint_in_example
Kaspik eadb4e2
Merge branch 'development' into dangerAndCI
Kaspik 8ab69e1
Re-enable cache
Kaspik d34226f
Fix swiftlint
Kaspik 8d20012
Switch to macOS for danger
Kaspik cddbf10
Update Dangerfile
Kaspik 5af92cf
Move script to subfolder
Kaspik 2dfbf65
Remove unused code
Kaspik df5635f
Merge pull request #1274 from MessageKit/dangerAndCI
Kaspik df61329
Merge branch 'master' into development
Kaspik f595893
Merge branch 'development' into cleanupSwift
Kaspik 1427c8b
Merge pull request #1281 from MessageKit/bguidolim-patch-1
Kaspik 33c2ad5
Add support to show splitview for iPads
ashleyng d52d57c
Merge branch 'master' into development
Kaspik 07fbb99
Merge branch 'development' into cleanupSwift
Kaspik 419e2e9
Get rid of Circle CI and unused travis file
Kaspik 71d1759
Update swiftlint
Kaspik 7dc8201
Merge pull request #1292 from MessageKit/cleanupCircleCI
austinwright c13bdf5
Merge branch 'development' into cleanupSwift
austinwright 42d32ab
Update project and example
Kaspik d3f722d
fix cache
Kaspik 9dfe24e
Merge pull request #1261 from MessageKit/cleanupSwift
Kaspik f345d80
Merge branch 'development' into Support_iPad_SplitView
Kaspik 176c6cd
documentation: Loading remote image messages in Example project
martinpucik 81d4387
build: Bump Cocoapods bundle version
martinpucik f28e72a
Changelog
martinpucik 94a263d
Update cache strategy with keys
Kaspik 5013fd8
Merge pull request #1295 from MessageKit/fixCache
austinwright 8bff5c9
Merge branch 'development' into documentation/remote_image_example
martinpucik 544bcb9
Cherry pick CI and infra changes from development to apply to master
Kaspik 6f3a7b2
Cherry pick changes for example app
Kaspik 6733905
Merge pull request #1294 from martinpucik/documentation/remote_image_…
Kaspik d6ffbf8
Merge branch 'development' into Support_iPad_SplitView
ashleyng bd193d9
fix spelling typo and rename UIImage extension filename
isupremedyou 83cda0e
Merge branch 'development' into master
Kaspik 4db71af
Fix Swiftlint
Kaspik 0c676da
Fix swiftlint
Kaspik 4ebb063
Udpate octokit
Kaspik cee0cec
Fix octokit
Kaspik 8155419
Merge pull request #1309 from MessageKit/fixSwiftlint
austinwright 4177220
Merge pull request #1297 from MessageKit/cherryPickCI
austinwright 768be3b
Merge branch 'development' into master
Kaspik 99d0719
Add LinkPreview support to MessageKit
bguidolim 474af4f
Refactoring to support font customization on LinkPreview type.
bguidolim fd7665b
Adds delegate method to configure LinkPreview's image view.
bguidolim 16a5180
fix typo rigt vs right
isupremedyou d633504
Merge branch 'master' of https://github.com/isupremedyou/MessageKit
isupremedyou a610389
Merge pull request #1306 from isupremedyou/master
Kaspik 0b0d151
disable
Kaspik 42834bc
Merge pull request #1312 from MessageKit/disableDangerForDevelopment
Kaspik 740a0c9
Merge branch 'development' into link-preview-support
Kaspik e7f832b
Merge branch 'development' into Support_iPad_SplitView
Kaspik dcdc54b
Change token & add development branch to danger
austinwright 5de37e4
Merge pull request #1314 from MessageKit/fix-danger-on-forks-1
austinwright e18b303
replace secrets with exposed token
austinwright a2246b9
Merge pull request #1317 from MessageKit/replace-secrets-with-exposed…
austinwright 3245157
put danger back
austinwright 93675ab
Merge pull request #1318 from MessageKit/put-danger-back
austinwright 1b2e807
Fix Manual link in README.md
alfredcc fadb781
Merge pull request #1326 from alfredcc/development
Kaspik f0ce300
Update README.md
2460ce4
Merge branch 'development' into mergeMaster
Kaspik 0be1804
Merge pull request #1338 from MessageKit/mergeMaster
Kaspik 4c97a49
Add shared template macro to insert the licence in every source file
kinoroy f84e868
Merge branch 'development' into licence-header
kinoroy bc5c5be
Merge pull request #1344 from MessageKit/licence-header
kinoroy d2a3489
Address code review
ashleyng c85a255
Added test for LinkPreviewMessageCell and entry to the Changelog.
bguidolim 9fda97b
Add codecov upload to test PR workflow
kinoroy ad21044
Merge pull request #1352 from MessageKit/github-actions-codecov
kinoroy 9806389
Merge branch 'development' into Support_iPad_SplitView
kinoroy 7827025
Merge branch 'development' into link-preview-support
kinoroy 3bcb7fc
Merge branch 'development' into patch-1
kinoroy aee2dee
Merge pull request #1284 from ashleyng/Support_iPad_SplitView
kinoroy fe37378
Merge branch 'development' into patch-1
kinoroy afde0b1
Merge pull request #1333 from alexBotteri/patch-1
kinoroy de410bd
Merge branch 'development' into link-preview-support
Kaspik dcaa0fe
Add 3 new categorized issue templates
kinoroy 9bdb62a
Update question/support template to include links
kinoroy 35aa3ee
Merge pull request #1356 from MessageKit/issue-templates
kinoroy 7ea2dee
Add animation performance info to FAQ
kinoroy ccc2648
Add padding info in the example proj for the InputBar
kinoroy 53a7dbc
Merge pull request #1360 from MessageKit/documentation-updates
kinoroy dd67cd2
Use messagesKey instead of string
musa-almatri 87446a2
Merge pull request #1364 from musa-almatri/patch-1
austinwright dadc83b
Fix syntax/scope error from #1364
austinwright f0c638d
Trivial commit to trigger danger
austinwright 530b63e
Merge pull request #1365 from MessageKit/Use-messagesKey-instead-of-s…
austinwright b83fd86
Update danger.yml
martinpucik c149898
Update README.md
martinpucik 137099d
Update README.md
martinpucik 8fa187d
Update README.md
martinpucik 26359c8
Update README.md
martinpucik eb085bf
Update danger.yml
martinpucik c5ce4de
Update ci_pr_tests.yml
martinpucik e0c2a76
Update ci_pr_framework.yml
martinpucik 8e1d435
Update ci_pr_example.yml
martinpucik fabc37f
Update README.md
martinpucik 4d4306f
Merge pull request #1372 from MessageKit/circleci_badge_readme
martinpucik 9b7730b
Merge branch 'master' into martinpucik-fix-danger-master
martinpucik 9567f87
Merge pull request #1367 from martinpucik/martinpucik-fix-danger-master
martinpucik 1918e55
Convert internal, static colors into color assets. (#1386)
kinoroy 8e7ce98
Update CONTRIBUTING.md
artemas-radik b0280fc
Merge branch 'master' into development-patch-from-master
kinoroy 39204db
Merge pull request #1398 from MessageKit/development-patch-from-master
kinoroy bbdb0f9
Merge branch 'development' into master
kinoroy 2572e3c
Merge pull request #1396 from ajradik/master
kinoroy 81395b6
Swift Package Manager support without RxSwift dependency (#1341)
martinpucik 02b03f3
Merge branch 'development' into link-preview-support
kinoroy bf97b5b
Merge pull request #1310 from bguidolim/link-preview-support
Kaspik 34a6686
Resolved a few typos.
artemas-radik 28fb0b9
empty commit for test re-run CL job
artemas-radik 5efe4f1
Merge pull request #1400 from MessageKit/ajradik-patch-1
kinoroy 555b750
Add HitchPin to apps using list in README
kevindice 5431da9
Merge pull request #1403 from HitchPin/master
kinoroy 5bb16cb
Add MessagesView wrapping MessageViewController
kinoroy 2436db9
Add SwiftUI Example to launchVC
kinoroy 2f6a2a1
Configure avatarView, currentSender
kinoroy f481519
Create SwiftUIExampleView to show use of MessagesView and data binding
kinoroy dbc7de1
Initialize initial messages inline, add some helper methods
kinoroy e9e524c
Keep an initialized @State variable so we don't scrollToBottom animat…
kinoroy 76ac072
add #if canImport for SwiftUI
kinoroy 0f3e7cf
Add message sending ability by conforming Coordinator to InputBarAcce…
kinoroy 6ff4bd7
Scroll to bottom on keyboard begins editing
kinoroy a9a1795
Add message top and bottom labels for name and time
kinoroy 93036d4
Remove unused getInitialMessages method
kinoroy 8b848df
Don't attempt to build with 32 bit architectures
kinoroy e440558
Address code review
kinoroy c2e41ae
Address code review
kinoroy c6771fe
Merge pull request #1410 from MessageKit/swiftui-example
kinoroy 8c035e6
Switch to new IBAV
Kaspik 0343016
Switch to right organization
Kaspik 9bd9bd6
Update example project
Kaspik cbc908b
Merge pull request #1427 from MessageKit/updateIBAV
Kaspik 5047d50
Merge branch 'master' into merge-pr-#1403-from-fork
Kaspik 39e4ad5
Merge pull request #1404 from MessageKit/merge-pr-#1403-from-fork
Kaspik b5d163f
Merge branch 'master' into development
Kaspik 2c1cbc1
Update example app
Kaspik 49697af
Merge pull request #1429 from MessageKit/mergemaster
Kaspik f165356
Bump kramdown from 2.1.0 to 2.3.0
dependabot[bot] f376900
Fixes incorrect animation of cells during keyboard drag-dismiss
kinoroy 92a6703
Add CHANGELOG entry
kinoroy 9054ea9
Merge pull request #1433 from MessageKit/fix-keyboard-animation
Kaspik c27a775
Merge pull request #1431 from MessageKit/dependabot/bundler/kramdown-…
austinwright fdac48d
Add missing changelog entries
kinoroy 528ca00
Merge pull request #1437 from MessageKit/missing-changelog-entries
kinoroy 8a499e7
Merge branch 'master' into development
Kaspik 9b3df35
Update changelog
Kaspik 5118f03
Fix Readme
Kaspik b508b31
Merge pull request #1439 from MessageKit/development
Kaspik 99b6a3e
Bump app and podspec
Kaspik 3fde158
Merge tag '3.2.0' into merge-upstream-3.2.0
manicmaniac d79d939
fixup! Resolve conflicts
manicmaniac ab772c4
fixup! Remove duplicate file references in pbxproj
manicmaniac c08c3dc
Fix test failure
manicmaniac c5bbddb
Add workaround to build MessageKit
manicmaniac 1f2d2eb
Back then macOS 11 was the latest
manicmaniac 7ecbe46
Add workaround for compilation error of PINRemoteImage
manicmaniac File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
--- | ||
name: "\U0001F41B Bug report" | ||
about: Create a report to help us improve | ||
title: '' | ||
labels: bug? | ||
assignees: '' | ||
|
||
--- | ||
|
||
<!-- | ||
Hi, thanks so much for opening an issue! 🤗 | ||
|
||
To better pinpoint (and solve) the issue you're experiencing, we could use some information on your behalf. | ||
--> | ||
|
||
**Describe the bug** | ||
A clear and concise description of what the bug is. | ||
|
||
**To Reproduce** | ||
Steps/code to reproduce the behavior: | ||
<!-- | ||
If the bug can be reproduced in the MessageKit example app, this is really helpful to us! | ||
|
||
In some cases it can be really helpful to provide a short example of your code. | ||
If so, please wrap these code blocks in backticks, like this: | ||
|
||
```swift | ||
*your code goes here* | ||
``` | ||
|
||
Please, *do not* submit screenshots of code, instead copy and paste it as above. | ||
--> | ||
|
||
**Expected behavior** | ||
A clear and concise description of what you expected to happen. | ||
|
||
**Screenshots** | ||
If applicable, add screenshots to help explain your problem. | ||
|
||
**Environment** | ||
- What version of MessageKit are you using? | ||
- What version of iOS are you running on? | ||
- What version of Swift are you running on? | ||
- What device(s) are you testing on? Are these simulators? | ||
- Is the issue you're experiencing reproducible in the example app? | ||
|
||
**Additional context** | ||
Add any other context about the problem here. | ||
<!-- When referencing a dependency manager-related issue (think CocoaPods, Carthage, SwiftPM), please add its configuration file and version here. --> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
--- | ||
name: "\U0001F4A1Feature request" | ||
about: Suggest an idea for this project | ||
title: '' | ||
labels: feature request | ||
assignees: '' | ||
|
||
--- | ||
|
||
<!-- Hey! Thanks so much for wanting to help improve MessageKit 😃 We always welcome PRs. If you would also be interested in implementing your feature request, please let us know! --> | ||
|
||
**Is your feature request related to a problem? Please describe.** | ||
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] | ||
|
||
**Describe the solution you'd like** | ||
A clear and concise description of what you want to happen. | ||
|
||
**Describe alternatives you've considered** | ||
A clear and concise description of any alternative solutions or features you've considered. | ||
|
||
**Additional context** | ||
Add any other context or screenshots about the feature request here. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
--- | ||
name: "❓ Question/Support" | ||
about: Ask a question about how to use MessageKit | ||
title: '' | ||
labels: question | ||
assignees: '' | ||
|
||
--- | ||
|
||
<!-- | ||
🛑 Read this 🛑 | ||
Before you open an issue. Please check the following to see if your question is answered there: | ||
- The quick start guide: https://github.com/MessageKit/MessageKit/blob/master/Documentation/QuickStart.md | ||
- The FAQ: https://github.com/MessageKit/MessageKit/blob/master/Documentation/FAQs.md | ||
- The example project: https://github.com/MessageKit/MessageKit/tree/master/Example | ||
Please also search through previous issues to see if your question was previously addressed. | ||
Also consider posting(/crossposting) your question to StackOverflow (with the tag 'messagekit'). | ||
|
||
⚠️ If you need to include code, please wrap it in backticks so it will get Swift highlighting like this: | ||
```swift | ||
*your code goes here* | ||
``` | ||
Please, do not upload screenshots of code. | ||
|
||
If relevant, please let us know the following things: | ||
|
||
- What version of MessageKit are you using? | ||
- What version of iOS are you running on? | ||
- What version of Swift are you running on? | ||
- What device(s) are you testing on? Are these simulators? | ||
- Is the issue you're experiencing reproducable in the example app? | ||
|
||
Please make sure your title describes your issue well. We will try our best to answer your question in a timely manner. Remember that this project is run by helpful volunteers, and we can't make any guarantees on turnaround time. | ||
--> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
name: Build Example app | ||
|
||
on: pull_request | ||
|
||
jobs: | ||
tests: | ||
name: Build Example app | ||
runs-on: macOS-11 | ||
steps: | ||
- name: Checkout the Git repository | ||
uses: actions/checkout@v2 | ||
- name: Cache Pods | ||
uses: actions/cache@v1 | ||
with: | ||
path: Example/Pods | ||
key: ${{ runner.os }}-example-${{ env.cache-name }}-pods-${{ hashFiles('**/Example/Podfile.lock') }} | ||
restore-keys: | | ||
${{ runner.os }}-example-${{ env.cache-name }}-pods- | ||
${{ runner.os }}-example-${{ env.cache-name }}- | ||
${{ runner.os }}-example- | ||
- name: Cache Gems | ||
uses: actions/cache@v1 | ||
with: | ||
path: vendor/bundle | ||
key: ${{ runner.os }}-example-${{ env.cache-name }}-gems-${{ hashFiles('**/Example/Gemfile.lock') }} | ||
restore-keys: | | ||
${{ runner.os }}-example-${{ env.cache-name }}-gems- | ||
${{ runner.os }}-example-${{ env.cache-name }}- | ||
${{ runner.os }}-example- | ||
- name: Build and run example project | ||
run: ./GitHubActions/build.sh example |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
name: Build Framework | ||
|
||
on: pull_request | ||
|
||
jobs: | ||
tests: | ||
name: Build Framework | ||
runs-on: macOS-11 | ||
steps: | ||
- name: Checkout the Git repository | ||
uses: actions/checkout@v2 | ||
- name: Cache Carthage | ||
uses: actions/cache@v1 | ||
with: | ||
path: Carthage | ||
key: ${{ runner.os }}-framework-${{ env.cache-name }}-carthage-${{ hashFiles('**/Cartfile.resolved') }} | ||
restore-keys: | | ||
${{ runner.os }}-framework-${{ env.cache-name }}-carthage- | ||
${{ runner.os }}-framework-${{ env.cache-name }}- | ||
${{ runner.os }}-framework- | ||
- name: Build framework | ||
run: ./GitHubActions/build.sh framework |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
name: Tests | ||
|
||
on: pull_request | ||
|
||
jobs: | ||
tests: | ||
name: Run Tests | ||
runs-on: macOS-11 | ||
steps: | ||
- name: Checkout the Git repository | ||
uses: actions/checkout@v2 | ||
- name: Cache Carthage | ||
uses: actions/cache@v1 | ||
with: | ||
path: Carthage | ||
key: ${{ runner.os }}-tests-${{ env.cache-name }}-carthage-${{ hashFiles('**/Cartfile.resolved') }} | ||
restore-keys: | | ||
${{ runner.os }}-tests-${{ env.cache-name }}-carthage- | ||
${{ runner.os }}-tests-${{ env.cache-name }}- | ||
${{ runner.os }}-tests- | ||
- name: Build and run tests | ||
run: ./GitHubActions/build.sh tests | ||
- name: Upload coverage to Codecov | ||
uses: codecov/[email protected] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
name: Danger | ||
|
||
on: | ||
pull_request: | ||
branches: | ||
- master | ||
# - development | ||
|
||
jobs: | ||
danger: | ||
name: Run Danger | ||
runs-on: macOS-11 | ||
steps: | ||
- name: Checkout the Git repository | ||
uses: actions/checkout@v2 | ||
with: | ||
fetch-depth: 0 | ||
- name: Cache Gems | ||
uses: actions/cache@v1 | ||
with: | ||
path: vendor/bundle | ||
key: ${{ runner.os }}-danger-${{ env.cache-name }}-gems-${{ hashFiles('**/Gemfile.lock') }} | ||
restore-keys: | | ||
${{ runner.os }}-danger-${{ env.cache-name }}-gems- | ||
${{ runner.os }}-danger-${{ env.cache-name }}- | ||
${{ runner.os }}-danger- | ||
- name: Run build script | ||
run: gem install bundler && bundle install && bundle exec danger --fail-on-errors=true | ||
env: | ||
DANGER_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current
macOS-latest
is equivalent tomacOS-12
.At that time,
macOS-11
should be the latest.upstream/3.2.0 dependes on Ruby 2.7 which is not installed in
macOS-12
butmacOS-11
.