Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix oom. if config resendRequestChunkSize. Loading data is batch #777

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

wajncn
Copy link

@wajncn wajncn commented Mar 18, 2024

Fixes #778

If the amount of data is particularly large 。

ResetOnLogon=N
ResetOnLogout=N
ResetOnDisconnect=N
ResetOnError=N

in quickfixj-initiator delete local quickfixj file。 restart quickfixj-acceptor OOM (If there is no excessive memory)

need config

ResendRequestChunkSize=1000

Can solve this problem

@wajncn
Copy link
Author

wajncn commented Mar 19, 2024

Can merge that pr?

throws IOException, InvalidMessage, FieldNotFound {

throws IOException, FieldNotFound {
// Prevent a one-time load of data that is too large, resulting in memory OOM。 if config resendRequestChunkSize。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please check that you don't use strange characters in the source code, e.g. as after

resendRequestChunkSize。

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, what I optimized was the problem of overloading at one time.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please check that you don't use strange characters in the source code, e.g. as after

resendRequestChunkSize。

Are you asking me to remove comments from the code?

@wajncn
Copy link
Author

wajncn commented Mar 31, 2024

@chrjohn oh~, you see see

@@ -3145,4 +3145,47 @@ public void testSend_ShouldKeepPossDupFlagAndOrigSendingTime_GivenAllowPosDupCon
assertTrue(sentMessage.getHeader().isSetField(PossDupFlag.FIELD));
assertTrue(sentMessage.getHeader().isSetField(OrigSendingTime.FIELD));
}


@Test
Copy link
Member

@chrjohn chrjohn Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this test do if you roll back your changes in the Session class? To me it looks like it just tests your session builder. But to be honest I am only looking at it on my mobile not IDE, so maybe I'm missing something.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what you mean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

if config ResendRequestChunkSize arg. is didn't work,probably oom
2 participants