ncm-spma: Next Generation Yum Module [WIP / early review] #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new version of the yum component that runs a lot faster than yum.pm. Tested on RHEL5u11 and RHEL6u6. So far only the 00-load.t unit test has been implemented.
…m-ng Conflicts: ncm-spma/src/main/pan/components/spma/schema.pan
…NDRICN/configuration-modules-core:yum-ng to yum-ng * commit '023550e359392e254b5f644076b1bb42e8e47df3': ncm-spma: Remove old module. Introduce Yum next generation SPMA module.
| @@ -27,6 +27,8 @@ | |||
| <properties> | |||
| <spma.ips.author>Mark R. Bannister</spma.ips.author> | |||
| <spma.ips.email>[email protected]</spma.ips.email> | |||
| <spma.yum-ng.author>Jindrich Novy</spma.yum-ng.author> | |||
There was a problem hiding this comment.
In fact is is 'yumng' without the dash - as the suffix is added from /software/components/spma/suffix which is 'ng' -> yumng.
| if ( exists( $a->{repository} ) ) { | ||
| foreach my $arch (@$arches) { | ||
| if ( $vers ne '_' ) { | ||
| push ( @pkl_v, ( unescape $name) . ';' . ( unescape $vers) . '.' . $arch ); |
There was a problem hiding this comment.
why is this joined as string and not a 2 element tuple?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wanted to publish this code for discussion before next week's workshop. Assistance/guidance on how to produce good unit tests and any other improvements would be much appreciated!
(Sorry about the merge conflicts, they and the commit history will get cleaned up in due course!)