Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncm-network: Remove legacy schema #1725

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

jrha
Copy link
Member

@jrha jrha commented Oct 22, 2024

Based on #1720.

The modernised schema has been proven to be equivalent and we really don't want to end up with the schema being forked.

@jrha jrha added this to the 24.10 milestone Oct 22, 2024
@jrha jrha changed the title Network rm legacy schema ncm-network: Remove legacy schema Oct 22, 2024
@aka7
Copy link
Contributor

aka7 commented Oct 29, 2024

this has been tested at MS and works on rhel9 which is where we use this.
our internal schema is bet more complicated due to previous legacy ncm-network code that we have in rhel7/8, so the LEGACY option actually works for us, but that's fine to be removed here.
is this likely to be merged soon or we expecting any further changes?

@jrha
Copy link
Member Author

jrha commented Oct 29, 2024

#1720 needs to be merged first, but otherwise this is good to go.

@jrha jrha marked this pull request as ready for review October 29, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants