ncm-network: add support for device configuration dropin file #1712
+46
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The schema update is only for nmstate backend, but I'm not totally sure how to include this in nmstate schema, from the separation @stdweird did. So some input would be appreciated. |
ned21
reviewed
Sep 11, 2024
provide support to create dropin file for device config and add option to add keep-configuration option
aka7
force-pushed
the
nm_device_config
branch
from
3718498
to
ec1da4e
Compare
|
@aka7 not sure the comment #1659 (comment) was supposed to be added here ? |
|
Probably. once the schema separation is understood and works, happy to
move it under nmstate schema only. I needed this quick to fix a bug we
noticed with network manager. So happy to move it under nmstate schema, if
that's what you mean?
…On Thu, 19 Sept 2024, 17:04 Stijn De Weirdt, ***@***.***> wrote:
@aka7 <https://github.com/aka7> not sure the comment #1659 (comment)
<#1659 (comment)>
was supposed to be added here ?
—
Reply to this email directly, view it on GitHub
<#1712 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADLYRYXCFXOEDJ4AZZCEX43ZXLYY5AVCNFSM6AAAAABOAWEUC2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRRGQZDMNRYGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Schema migration in #1720. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
provide support to create drop-in file for device config and add option to add keep-configuration option
fixes 1711
To able to turn off device keep-configuration option.
None.