Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule based editor #151

Merged
merged 22 commits into from
May 10, 2016
Merged

Rule based editor #151

merged 22 commits into from
May 10, 2016

Commits on Apr 24, 2016

  1. Import Rule-based Editor from ncm-dpmlfc

    @jouvin
    jouvin committed Apr 24, 2016
    Configuration menu
    Copy the full SHA
    4cc3f7d View commit details
    Browse the repository at this point in the history

  2. RuleBasedEditor.pm: fix calling sequence for reporting methods

    @jouvin
    jouvin committed Apr 24, 2016
    Configuration menu
    Copy the full SHA
    0d01b25 View commit details
    Browse the repository at this point in the history

  3. import rule-based editor unittests from ncm-dpmlfc (value_format)

    @jouvin
    jouvin committed Apr 24, 2016
    Configuration menu
    Copy the full SHA
    f5a2f06 View commit details
    Browse the repository at this point in the history

  4. RuleBasedEditor: import unit test remove_variable from ncm-dpmlfc 

    - Fix typo in _apply_rules() calling sequence
    @jouvin
    jouvin committed Apr 24, 2016
    Configuration menu
    Copy the full SHA
    70e02a8 View commit details
    Browse the repository at this point in the history

  5. RuleBasedEditor: import unit test build_line_pattern.t from ncm-dpmlfc

    @jouvin
    jouvin committed Apr 24, 2016
    Configuration menu
    Copy the full SHA
    dea2dc5 View commit details
    Browse the repository at this point in the history

  6. RuleBasedEditor: import unit test rule_parser.t from ncm-dpmlfc

    @jouvin
    jouvin committed Apr 24, 2016
    Configuration menu
    Copy the full SHA
    8f7e5b3 View commit details
    Browse the repository at this point in the history

  7. RuleBasedEditor: update constant names to be independent from ncm-dpm… 

    …lfc/xrootd

- Unit tests updated
    @jouvin
    jouvin committed Apr 24, 2016
    Configuration menu
    Copy the full SHA
    8870bee View commit details
    Browse the repository at this point in the history

  8. RuleBasedEditor: misc. refactoring in unit tests

    @jouvin
    jouvin committed Apr 24, 2016
    Configuration menu
    Copy the full SHA
    9aa3d33 View commit details
    Browse the repository at this point in the history

  9. RuleBasedEditor: document rule format + misc. doc improvements

    @jouvin
    jouvin committed Apr 24, 2016
    Configuration menu
    Copy the full SHA
    da657f1 View commit details
    Browse the repository at this point in the history

  10. RuleBasedEditor: convert into a subclass of the FileEditor

    @jouvin
    jouvin committed Apr 24, 2016
    Configuration menu
    Copy the full SHA
    8f23841 View commit details
    Browse the repository at this point in the history

  11. RuleBaseEditor.pm: address initial comments by @stdweird in quattor#151

    @jouvin
    jouvin committed Apr 24, 2016
    Configuration menu
    Copy the full SHA
    6f77a5a View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2016

  1. RuleBasedEditor: general reformatting with perl-Tidy 

    - perl-Tidy options used: -lp -l=132 -cti=1 -nolq -pt=2 -sbt=2 -bt=2 -sbl -boc -cab=3 -nbbc -mbl=3
    @jouvin
    jouvin committed Apr 25, 2016
    Configuration menu
    Copy the full SHA
    55eb207 View commit details
    Browse the repository at this point in the history

  2. RuleBasedEditor: updateFile() returns 1 on success (instead of 0)

    @jouvin
    jouvin committed Apr 25, 2016
    Configuration menu
    Copy the full SHA
    fc9e50e View commit details
    Browse the repository at this point in the history

  3. FileEditor: remove unnecessary 'use' for modules in 'use parent'

    @jouvin
    jouvin committed Apr 25, 2016
    Configuration menu
    Copy the full SHA
    e317678 View commit details
    Browse the repository at this point in the history

  4. RuleBasedEditor: improve pod documentation 

    - Addresses @stdwerid's second serie of comments in quattor#151.
- No code change
    @jouvin
    jouvin committed Apr 25, 2016
    Configuration menu
    Copy the full SHA
    fb50d1d View commit details
    Browse the repository at this point in the history

  5. RuleBasedEditor: cleanup in tests 

    - Replace use of testapp by Test::Quattor::Object
    @jouvin
    jouvin committed Apr 25, 2016
    Configuration menu
    Copy the full SHA
    2478919 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2016

  1. RuleBasedEditor: address @ned21 comments in PR 151 

    - Document return value for all methods
- Comments clarification
- fix inappropriate return value for some methods (1 instead of undef)
    @jouvin
    jouvin committed May 8, 2016
    Configuration menu
    Copy the full SHA
    23469cb View commit details
    Browse the repository at this point in the history

Commits on May 9, 2016

  1. RuleBaseEditor: rename method _removeConfigLine into _commentConfigLine

    @jouvin
    jouvin committed May 9, 2016
    Configuration menu
    Copy the full SHA
    c9b50c2 View commit details
    Browse the repository at this point in the history

  2. RuleBasedEditor: comment clarifications and typo fixes 

    - Also add handling of undef return value by some methods after an internal error
    @jouvin
    jouvin committed May 9, 2016
    Configuration menu
    Copy the full SHA
    0b1529f View commit details
    Browse the repository at this point in the history

  3. RuleBasedEditor: cleanup of method return values

    @jouvin
    jouvin committed May 9, 2016
    Configuration menu
    Copy the full SHA
    f0c06fb View commit details
    Browse the repository at this point in the history

  4. RuleBasedEditor: additional comment cleanups and clarifications 

    - Also includes some code reformatting
    @jouvin
    jouvin committed May 9, 2016
    Configuration menu
    Copy the full SHA
    a3a4a03 View commit details
    Browse the repository at this point in the history

  5. RuleBasedEditor: fix a regexp not compatible with perl 5.8 (SL5)

    @jouvin
    jouvin committed May 9, 2016
    Configuration menu
    Copy the full SHA
    95b3896 View commit details
    Browse the repository at this point in the history