Add support for new Scroll View mode of Revealjs #11034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Quarto This is a new feature from 1.5 : https://revealjs.com/scroll-view/
and deactivate some slidechanged event as they are not compatible with new scrollview DOM structure
cderv
force-pushed
the
revealjs/scroll-view
branch
from
5f64b91
to
c39b294
Compare
|
Let's document after merging as discussed. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new feature from 1.5 : https://revealjs.com/scroll-view/
This PR adds:
Support for configuration through YAML
scroll-viewkey.scroll-view: trueis a shortcut formeaning to start the presentation in scroll view by default.
a menu tool item to toggle scroll view on and off, associated with new R keyboard shortcut
Adapt our custom footer processing to work in Scroll view mode.
tests for our Quarto specific support (not for the scroll view feature itself as this is revealjs)
There may still be some other side effect I did not find.
We could also so some still choices by default (like hide chalkboard button by default in scroll mode 🤷 )
I think we may discover a few side effect of this new mode, possibly also because of some Revealjs bug. We'll see
TO-DO