Wider S3 deployment options #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set default S3 URL to None for boto, so the library can construct the URL from the region, thereby allowing intra-VPC S3 access to work instead of always relying on public URL - Set encryption to updated s3v4 - Use get bucket location as a test for connectivity instead of creating bucket, which work work well when there are a lot of workers starting at the same time - Better error message when connectivity failed
fauxpark
requested changes
Dec 7, 2022
| @@ -41,17 +41,17 @@ | |||
| endpoint_url=S3_HOST, | |||
| aws_access_key_id=S3_ACCESS_KEY, | |||
| aws_secret_access_key=S3_SECRET_KEY, | |||
| config=botocore.client.Config(signature_version='s3'), | |||
| config=botocore.config.Config(signature_version='s3v4') | |||
| ) | ||
|
|
||
| # Check to see if S3 is working, and if not print an error in the log. | ||
| for bucket in [S3_BUCKET, COMPILE_S3_BUCKET]: | ||
| try: | ||
| s3.create_bucket(Bucket=bucket) | ||
| s3.get_bucket_location(Bucket=bucket) |
There was a problem hiding this comment.
create_bucket is needed for qmk_web_stack.
Suggested change
| s3.get_bucket_location(Bucket=bucket) | |
| s3.create_bucket(Bucket=bucket) |
tzarc
force-pushed
the
master
branch
2 times, most recently
from
0a096f1
to
daad9ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thereby allowing intra-VPC S3 access to work instead of always relying on public URL
which work work well when there are a lot of workers starting at the same time