doc: update codereview docs for team1. #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlJi
reviewed
Feb 26, 2024
CarlJi
reviewed
Feb 26, 2024
|
|
||
|
|
||
| * https://github.com/goplus/community/pull/148#discussion_r1494609866 | ||
| * 代码风格，尽量遵循Go的风格，尤其是命名，减少map等不固定长度的数据结构作为参数或者返回值 |
There was a problem hiding this comment.
减少map等不固定长度的数据结构作为参数或者返回值 这一句哪里有出处吗？
There was a problem hiding this comment.
Golang好像没有具体的条例限制，但是有侧面反应推荐使用结构体，主要基于类型安全和代码可读性的考虑。结构体提供了明确的类型信息
部分社区中的反馈：
There was a problem hiding this comment.
在一些场景下，明确的结构体确实是能增强可读性，但直接推到为结论 减少map等不固定长度的数据结构作为参数或者返回值 有点过于武断。
实际上在我看来，在具体业务场景下这些决策是顺水渠成的。
比如我们这里，确实是不推荐直接用map，因为这里它应该固定长度的，且有明确语义。而这个语义，可能还需要别人理解的，所以用一个明确的名字会更好。
CarlJi
reviewed
Feb 26, 2024
CarlJi
reviewed
Feb 26, 2024
IRONICBo
force-pushed
the
docs/20240221-review-comments
branch
from
6a98284
to
8fea5f6
Compare
IRONICBo
force-pushed
the
docs/20240221-review-comments
branch
from
8fea5f6
to
c8b3c1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update our review comments in team1