github support multi-line comment

qiniu · Feb 19, 2024 · 5edc4eb · 5edc4eb
1 parent 79410a6
commit 5edc4eb
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 7 deletions.
diff --git a/github.go b/github.go
@@ -174,13 +174,25 @@ func buildPullRequestCommentBody(linterName string, lintErrs map[string][]linter
 				message := fmt.Sprintf("[%s] %s\n%s",
 					linterName, lintErr.Message, linters.CommentFooter)
 
-				comments = append(comments, &github.PullRequestComment{
-					Body:     github.String(message),
-					Path:     github.String(file),
-					Line:     github.Int(lintErr.Line),
-					Side:     github.String("RIGHT"),
-					CommitID: github.String(commitID),
-				})
+				if lintErr.Strat_line != 0 {
+					comments = append(comments, &github.PullRequestComment{
+						Body:      github.String(message),
+						Path:      github.String(file),
+						Line:      github.Int(lintErr.Line),
+						StartLine: github.Int(lintErr.Strat_line),
+						StartSide: github.String("RIGHT"),
+						Side:      github.String("RIGHT"),
+						CommitID:  github.String(commitID),
+					})
+				} else {
+					comments = append(comments, &github.PullRequestComment{
+						Body:     github.String(message),
+						Path:     github.String(file),
+						Line:     github.Int(lintErr.Line),
+						Side:     github.String("RIGHT"),
+						CommitID: github.String(commitID),
+					})
+				}
 			}
 		}
 	}

diff --git a/internal/linters/linters.go b/internal/linters/linters.go
@@ -89,6 +89,8 @@ type LinterOutput struct {
 	Column int
 	// Message is the staticcheck Message
 	Message string
+	//Strat_line required when using multi-line comments
+	StratLine int
 }
 
 // Agent knows necessary information from reviewbot.