Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two bugs related to changing taxonomic level in the barplot #126

Merged
merged 11 commits into from
Jul 26, 2019

Commits on May 10, 2019

  1. Configuration menu
    Copy the full SHA
    4e1d652 View commit details
    Browse the repository at this point in the history
  2. ENH: Remove default padding on width slider

    This looks a lot nicer.
    fedarko committed May 10, 2019
    Configuration menu
    Copy the full SHA
    c72393a View commit details
    Browse the repository at this point in the history
  3. MAINT: Define the default bar width in one place

    Will make it easier to adjust this in the future, if desired.
    fedarko committed May 10, 2019
    Configuration menu
    Copy the full SHA
    a29d383 View commit details
    Browse the repository at this point in the history
  4. MAINT: Increase min and max bar sizes

    The min size increase should at least prevent the labels from getting
    squished together.
    fedarko committed May 10, 2019
    Configuration menu
    Copy the full SHA
    67168ba View commit details
    Browse the repository at this point in the history
  5. BUG: Get width slider value from render()

    TODOs remaining:
    -Preserve the bar width on changing taxonomic level
    -When filtering the bar chart to show a certain taxon/level, ensure
     that this filtering is respected upon changing the bar width.
    fedarko committed May 10, 2019
    Configuration menu
    Copy the full SHA
    56eeaa1 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2019

  1. Configuration menu
    Copy the full SHA
    7638957 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2019

  1. Configuration menu
    Copy the full SHA
    5c8404e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8e1fa42 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2019

  1. Configuration menu
    Copy the full SHA
    512fb8b View commit details
    Browse the repository at this point in the history
  2. BUG: Preserve bar width when tax. level changed

    This is done by passing bar width to init(), which in turn is now
    done by a "state" object that init() accepts as an argument.
    
    It seems like some of the open problems in the bar plot visualization
    (e.g. qiime2#91) could be addressed by storing more information about the
    visualization's state. (Not sure just passing this around between
    functions is the *best* way to structure things, though.)
    fedarko committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    30a17d2 View commit details
    Browse the repository at this point in the history
  3. BUG: Make color scheme persist across tax levels

    Previously, changing the taxonomic level would revert the color
    scheme back to the default (schemeAccent). Now, it should stick
    with whatever the user had selected.
    
    This is done by using the new "state" option of init(). I imagine we
    could also use this in the future for outstanding issues like qiime2#87.
    fedarko committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    ef72b55 View commit details
    Browse the repository at this point in the history