-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix two bugs related to changing taxonomic level in the barplot #126
Commits on May 10, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 4e1d652 - Browse repository at this point
Copy the full SHA 4e1d652View commit details -
Configuration menu - View commit details
-
Copy full SHA for c72393a - Browse repository at this point
Copy the full SHA c72393aView commit details -
MAINT: Define the default bar width in one place
Will make it easier to adjust this in the future, if desired.
Configuration menu - View commit details
-
Copy full SHA for a29d383 - Browse repository at this point
Copy the full SHA a29d383View commit details -
MAINT: Increase min and max bar sizes
The min size increase should at least prevent the labels from getting squished together.
Configuration menu - View commit details
-
Copy full SHA for 67168ba - Browse repository at this point
Copy the full SHA 67168baView commit details -
BUG: Get width slider value from render()
TODOs remaining: -Preserve the bar width on changing taxonomic level -When filtering the bar chart to show a certain taxon/level, ensure that this filtering is respected upon changing the bar width.
Configuration menu - View commit details
-
Copy full SHA for 56eeaa1 - Browse repository at this point
Copy the full SHA 56eeaa1View commit details
Commits on May 31, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 7638957 - Browse repository at this point
Copy the full SHA 7638957View commit details
Commits on Jun 13, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 5c8404e - Browse repository at this point
Copy the full SHA 5c8404eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e1fa42 - Browse repository at this point
Copy the full SHA 8e1fa42View commit details
Commits on Jul 22, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 512fb8b - Browse repository at this point
Copy the full SHA 512fb8bView commit details -
BUG: Preserve bar width when tax. level changed
This is done by passing bar width to init(), which in turn is now done by a "state" object that init() accepts as an argument. It seems like some of the open problems in the bar plot visualization (e.g. qiime2#91) could be addressed by storing more information about the visualization's state. (Not sure just passing this around between functions is the *best* way to structure things, though.)
Configuration menu - View commit details
-
Copy full SHA for 30a17d2 - Browse repository at this point
Copy the full SHA 30a17d2View commit details -
BUG: Make color scheme persist across tax levels
Previously, changing the taxonomic level would revert the color scheme back to the default (schemeAccent). Now, it should stick with whatever the user had selected. This is done by using the new "state" option of init(). I imagine we could also use this in the future for outstanding issues like qiime2#87.
Configuration menu - View commit details
-
Copy full SHA for ef72b55 - Browse repository at this point
Copy the full SHA ef72b55View commit details