Skip to content
This repository has been archived by the owner on Apr 16, 2024. It is now read-only.

IMP: removes awscli from requirements.txt #62

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

cduvallet
Copy link
Contributor

@cduvallet cduvallet commented Sep 8, 2023

For some reason, when sphinx is the first requirement listed then pip install -r requirements.txt runs through an exhaustive search of awscli versions which takes a really long time. Swapping the order fixes the issue.

Tested:

pip install -r requirements.txt
make dirhtml

Which worked!

@cduvallet
Copy link
Contributor Author

Though now that I think about it, you probably only need awscli to actually deploy the changes, right? So as a developer trying to test my changes to the documentation, all I really need is sphinx right? So maybe it's better to update the developer docs with just that, or make a requirements.txt for deployers separate from contributors?

@gregcaporaso
Copy link
Member

Thanks for the PR @cduvallet, and sorry for the radio silence. We're re-working how we're managing issues/PRs to avoid losing track of incoming stuff. @lizgehret will take care of this and your other dev-docs PR.

@lizgehret
Copy link
Member

Hey @cduvallet! I agree with you re: only needing sphinx as a developer testing changes locally. I'm happy to update the dev docs with separate instructions for development vs. deployment, unless you'd like to?

@cduvallet
Copy link
Contributor Author

Awesome! Please go ahead and make the updates 😸

@lizgehret
Copy link
Member

Okay, for posterity - I removed awscli from requirements.txt and added that into the environment creation for dev-docs deployment (in cap-lab-secrets repo).

I'll go ahead and get this merged, thanks again @cduvallet!

@lizgehret lizgehret merged commit a6b9740 into qiime2:master Nov 17, 2023
@lizgehret lizgehret changed the title Swap requirements order IMP: removes awscli from requirements.txt Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

3 participants