-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.2 #999
Conversation
@stavros11 @hay-k just to be clear: I'm not requesting an actual review, all the content has already been reviewed before... |
They are just checking the result shape, which is already covered in dedicated tests
Mostly redundant, it should be replaced with a test on the exact type returned by Platform.execute, in #964
For dummy it is a trivial combination of a sweeper, and addressing a coupler, which are both separately tested
The fast reset option is ineffective on dummy, and it's not yet implemented in any driver either
Extend `Config` beyond channels
Clean dummy tests
…quivalent to the previous
Make `Sweeper` pydantic `Model` and introduce `range`
Split RX from RXY
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #999 +/- ##
==========================================
+ Coverage 51.58% 51.95% +0.37%
==========================================
Files 58 63 +5
Lines 2749 2808 +59
==========================================
+ Hits 1418 1459 +41
- Misses 1331 1349 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Make execution parameters private
QM driver fixes
Fix some docstrings
Update README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a final test on hardware and the updated routines seem to work: http://login.qrccluster.com:9000/xLTo088LTjKn-W5Bnr5Pqw==
Of course, this doesn't cover everything we would like to do with qibolab 0.2, but hopefully we will be able to fix potential bugs in later releases without breaking the public interface.
@alecandido @scarrazza if you agree, we can merge this and release.
I agree, thanks a lot for the final tests! |
Let me release qibo first and then update poetry before merging this. |
@alecandido @stavros11 @hay-k thanks a lot for the great effort! |
Since we're now blocking features on 0.1, and we have a dedicated branch, https://github.com/qiboteam/qibolab/tree/0.1, it should be the proper time to make https://github.com/qiboteam/qibolab/tree/0.2 the actual
main
(i.e. the branch receiving new features).