New version video similarity library #1356
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version allows to compare similarity of video files, that are shorter than 30 seconds
Not mergable yet, because currently app depends on library from commit Farmadupe/vid_dup_finder_lib@4015aed8efc83bf9f6643158bc714f0767d6de8a(czkawka only can use version released on crates.io)
Second problem are random panics, library needs to be tested with fuzzer - recent panic I found with integer overflow(trying to catch it, but it is also possible, that I used wrong version and all panics are already fixed).
Also current version, not allows to check if ffmpeg is installed
Image-rs still is used in version 0.24 - this causes version duplication and czkawka user needs to compile both 0.24 and 0.25 versions