Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin dependencies #539

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Unpin dependencies #539

merged 2 commits into from
Mar 20, 2024

Conversation

joecummings
Copy link
Contributor

@joecummings joecummings commented Mar 20, 2024

Context

Closes #325 , enables work with Evals

Changelog

  • Remove hard dependencies

Testing

CI (Does a fresh install everytime and with E2E recipe tests, runs actual commands for confidence)

Copy link

pytorch-bot bot commented Mar 20, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/539

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 68ebea4 with merge base 80a2114 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 20, 2024
Copy link

netlify bot commented Mar 20, 2024

Deploy Preview for torchtune-preview ready!

Name Link
🔨 Latest commit 68ebea4
🔍 Latest deploy log https://app.netlify.com/sites/torchtune-preview/deploys/65fb5139c137140008b89a2e
😎 Deploy Preview https://deploy-preview-539--torchtune-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joecummings joecummings marked this pull request as ready for review March 20, 2024 21:09
omegaconf>=2.3.0
sentencepiece
tqdm
omegaconf

# Evaluation
lm_eval==0.4.1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not unpinning this yet as it will be addressed by eval PR.

Copy link
Contributor

@kartikayk kartikayk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You had me at "unpin"

@joecummings joecummings merged commit 3579827 into main Mar 20, 2024
21 checks passed
@joecummings joecummings deleted the unpin-dependencies branch March 20, 2024 21:25
@NicolasHug
Copy link
Member

Thank you @joecummings 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't pin versions of dependencies
4 participants