Remove unused FSDP1 components

[krammnic]

Context

What is the purpose of this PR? Is it to

• add a new feature
• fix a bug
• update tests and/or documentation
• Clean up

Please link to any issues this PR addresses.

Changelog

What are the changes made in this PR?

• [Cleanup] Delete FSDP1 code #1897

Test plan

Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.

• run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
• add unit tests for any new functionality
• update docstrings for any new or updated methods or classes
• run unit tests via pytest tests
• run recipe tests via pytest tests -m integration_test
• manually run any new or modified recipes with sufficient proof of correctness
• include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

UX

If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example

• I did not change any public API
• I have added an example to docs or docstrings

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1933

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 9d12533 with merge base e99b890 ():

NEW FAILURE - The following job has failed:

• Build Docs / build_docs (3.11) (gh)
  sphinx.errors.SphinxWarning: [autosummary] failed to import torchtune.modules.peft.validate_state_dict_for_lora.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[krammnic]

Probably need to remove relations to docs

[ebsmothers]

Thanks for the PR! Looking at the code changes now, but at least for the doc build job failure you will need to remove this line (you can check other rst files the same folder for any other APIs you've removed, their references will need to be removed as well)

[ebsmothers]

We should be able to do it without these extra arguments. You should be able to leverage base_missing, base_unexpected, lora_missing, lora_unexpected in the DPO recipe to use this API as is (may just need to move the call to validate_missing_and_unexpected_for_lora down a few lines)

[ebsmothers]

Same with all the code from here on down.. the changes should be doable without any modifications to this function