-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for QAT + LoRA #1931
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1931
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New Failures, 5 Cancelled JobsAs of commit 1a48a20 with merge base f560cbb (): NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@@ -0,0 +1,24 @@ | |||
# Copyright (c) Meta Platforms, Inc. and affiliates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will delete these files before land
e20e891
to
d09c71f
Compare
TODO: write this
d09c71f
to
1a48a20
Compare
# TODO: Expose fake quantize configs from torchao so we can get them | ||
# directly from the quantizer. For now, we hardcode the configs for 8da4w. | ||
# E.g. activation_config = quantizer.get_activation_fake_quantize_config() | ||
# E.g. weight_config = quantizer.get_weight_fake_quantize_config() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in pytorch/ao#1214
TODO: write this
Helpful code review commands:
Test Plan
Unit tests:
Manual tests:
Results: