Skip to content
This repository has been archived by the owner on Aug 28, 2024. It is now read-only.

fix/Questionanswering-App #290

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix/Questionanswering-App #290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
036565e
Bump Pytorch to 1.13.0
Dec 20, 2022
cf6a3ba
change pt version
Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion QuestionAnswering/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ In this demo app, written in Kotlin, we'll show how to quantize and convert the

* PyTorch 1.10.0 or later (Optional)
* Python 3.8 (Optional)
* Android Pytorch library org.pytorch:pytorch_android_lite:1.10.0
* Android Pytorch library org.pytorch:pytorch_android_lite:1.13.0
* Android Studio 4.0.1 or later

## Quick Start
Expand Down
11 changes: 8 additions & 3 deletions QuestionAnswering/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@ apply plugin: 'com.android.application'
apply plugin: 'kotlin-android'

android {
compileSdkVersion 30
compileSdkVersion 33
buildToolsVersion "30.0.2"

defaultConfig {
applicationId "org.pytorch.demo.questionanswering"
minSdkVersion 28
targetSdkVersion 30
targetSdkVersion 33
versionCode 1
versionName "1.0"

Expand All @@ -35,7 +35,12 @@ dependencies {
implementation "androidx.core:core-ktx:1.6.0"
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"

implementation 'org.pytorch:pytorch_android_lite:1.10.0'
implementation 'com.facebook.fbjni:fbjni-java-only:0.0.3'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for adding the fbjni?


implementation 'org.pytorch:pytorch_android_lite:1.13.0'

// Uncomment below line for using libs built from src
// implementation(name:'pytorch_android-release', ext:'aar')
}
repositories {
mavenCentral()
Expand Down
3 changes: 2 additions & 1 deletion QuestionAnswering/app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
android:roundIcon="@mipmap/ic_launcher_round"
android:supportsRtl="true"
android:theme="@style/AppTheme">
<activity android:name=".MainActivity">
<activity android:name=".MainActivity"
android:exported="true">
<intent-filter>
<action android:name="android.intent.action.MAIN" />

Expand Down
3 changes: 3 additions & 0 deletions QuestionAnswering/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ allprojects {
repositories {
google()
jcenter()
flatDir {
dirs 'libs'
}
}
}

Expand Down