Merge docker refactor #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## tl;dr Refactored both the dockerfile and docker-compose files to improve performance, build size/caching, and maintainability. ## High level changes - `docker-compose*.yml` - container name - build context and dockerfile - hostname - platform w/fallback - read .env for platform and sane compose defaults - explicit bridge network - workdir - `Dockerfile` - set syntax (future proof w/heredocs and interpolation) - pin image - multistage builder - pip, python, and local env vars - clean up build deps from apk - update pip before installing requirements - copy build deps to runner stage - set workdir (overridden by compose) - label for github actions builds - `docker.yml` - CI to build the docker image and push to either ghcr.io by default or dockerhub when `REGISTRY_URL` is set to docker.io - `docker-entrypoint.sh` - get interpreter from env - remove bashisms (posix sh) - double quote cli args to avoid word splitting - `.dockerignore`: add exclusions - `.env.example` - set compose file name (useful for multiple compose files) - remove orphans by default - platform for local builds on arm - `.dive-ci`: analyze image to reduce build size - `.hadolint.yaml`: lint Dockerfile
- descriptions of exclusions/inclusion - included .env.example for docker builds
This one is optional, but I've found editorconfig to be invaluable when working on projects with more than two devs. Happy to remove or edit per the maintainers. https://EditorConfig.org
- opus-dev and ca-certificates reinstated - sorted runtime deps - changed builder workdir to match runner
Gets description from repo instead of dockerfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test CI on master branch