feat: add extras, no-directory, no-root options #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the following options from Poetry installer command: * `--no-root` * `--no-directory` * `-E, --extras=EXTRAS` * `--all-extras` These are useful for creating different combinations of archives and Docker layers. Extras logic is a simplified variant of the full install command, but works for all practical cases. Maybe Poetry could share them as easily as the group options.
radoering
reviewed
Oct 8, 2023
Comment on lines
+54
to
+57
| if self.option("all-extras"): | ||
| extras.update(self.poetry.package.extras) | ||
| for extra in self.option("extras", []): | ||
| extras.update(extra.split()) |
There was a problem hiding this comment.
poetry install does not accept both flags at the same time. Maybe, we should print the same error for consistency?
radoering
requested changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following options from Poetry installer command:
--no-root--no-directory-E, --extras=EXTRAS--all-extrasThese are useful for creating different combinations of archives and Docker layers.
Extras logic is a simplified variant of the full install command, but works for all practical cases. Maybe Poetry could share them as easily as the group options.