Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert dict entry to dataclass & typing #239

Merged
merged 13 commits into from
Oct 17, 2024
Merged

convert dict entry to dataclass & typing #239

merged 13 commits into from
Oct 17, 2024

Conversation

Borda
Copy link
Contributor

@Borda Borda commented Oct 16, 2024

improve navigation within the codebase and make the code easier to b=navigate with IDE

@Borda Borda requested a review from shaypal5 as a code owner October 16, 2024 13:18
@Borda Borda marked this pull request as draft October 16, 2024 14:11
@Borda Borda marked this pull request as ready for review October 16, 2024 19:37
@Borda Borda mentioned this pull request Oct 16, 2024
Merged
shaypal5
shaypal5 approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@shaypal5 shaypal5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! A custom class for a cache entry was a long time coming. What a pleasure to have you pushing this package forward. :)

@shaypal5 shaypal5 merged commit 731b66e into master Oct 17, 2024
33 checks passed
@shaypal5 shaypal5 deleted the dataslass/CacheEntry branch October 17, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaypal5 shaypal5 shaypal5 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Borda @shaypal5