Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backport js changes to python #213

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: backport js changes to python #213

wants to merge 3 commits into from

Conversation

guibescos
Copy link
Contributor

@guibescos guibescos commented Nov 5, 2024

Apply the changes from @kamino-finance/limo-sdk 0.6.0 to the Python sdk.
TODO:

  • Apply rounding errors fix
  • Fix WSOL as output

@guibescos guibescos changed the title Bump/pyth sdk fix: backport js changes to python Nov 5, 2024
@guibescos guibescos marked this pull request as ready for review November 5, 2024 18:55
@@ -193,6 +193,9 @@ async def take_order_ix(
input_mint_decimals: int,
output_mint_decimals: int,
express_relay_program_id: Pubkey,
permissionless_tip_lamports: int = 0,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we actually don't want to expose these to searchers. it's more for testing without going through the auction server. So we can just remove it here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants