Feat/dex router #212
Open
Feat/dex router #212
+4,261
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m30m
reviewed
Nov 5, 2024
scripts/dex-router/src/index.ts
Outdated
| ).filter((acc) => acc !== null); | ||
|
|
||
| return addressLookupTableAccountInfos.map((accountInfo, index) => { | ||
| const addressLookupTableAddress = keys[index]; |
There was a problem hiding this comment.
the order might not be right if we filtered out a null account. we should do the filtering here and probbably also log it or even throw an error if the lookup table doesn't exist
There was a problem hiding this comment.
agreed on the indexing. but probably not throw an error since the tx should be valid without it. will throw a warning
|
|
||
| const { | ||
| tokenLedgerInstruction, | ||
| computeBudgetInstructions, |
There was a problem hiding this comment.
don't you want to actually use them for now?
|
|
||
| export class JupiterRouter implements Router { | ||
| private chainId: string; | ||
| private connection: Connection; |
There was a problem hiding this comment.
i designed the interface this way bc for other routers we may need to pass in a connection. for now i can remove it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a script to route limit orders to on-chain liquidity