Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/update loop gone #20

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Fix/update loop gone #20

merged 2 commits into from
Oct 18, 2023

Conversation

ali-bahjati
Copy link
Contributor

@ali-bahjati ali-bahjati commented Oct 18, 2023

From #19

https://docs.python.org/3/library/asyncio-task.html#creating-tasks

"Save a reference to the result of this function, to avoid a task disappearing mid-execution. The event loop only keeps weak references to tasks. A task that isn’t referenced elsewhere may get garbage collected at any time, even before it’s done."

Building off the example i end up with a publisher that suddenly dies. It looks like some places violate the documentation recommendations.

@ali-bahjati ali-bahjati merged commit 3a5cea9 into main Oct 18, 2023
2 checks passed
@ali-bahjati ali-bahjati deleted the fix/update-loop-gone branch October 18, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants