Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note about PySide6 exception capture and fix tests #525

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Add note about PySide6 exception capture and fix tests #525

merged 3 commits into from
Oct 19, 2023

Commits on Oct 19, 2023

  1. Add note about PySide6 exception capture and fix tests 

    PySide6 does its own exception capture during events, re-raising them when control gets back to Python.

This feature causes our own exception capturing mechanism to not work, but it is not needed anyway, because the exception re-raising done by PySide6 contains a better traceback than it is possible for pytest-qt to provide, given it can re-raise at the exact point where control was given back to Python.

Besides noting this in the documentation, also accomodate the tests.
    @nicoddemus
    nicoddemus committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    25c9071 View commit details
    Browse the repository at this point in the history

  2. Remove obsolete skipif for Python 2

    @nicoddemus
    nicoddemus committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    74cbc3b View commit details
    Browse the repository at this point in the history

  3. Add explicit docs requirements 

    ReadTheDocs no longer installs rtd-theme by default in its virtual environments, so we
need to explicitly install it.
    @nicoddemus
    nicoddemus committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    878296e View commit details
    Browse the repository at this point in the history