Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added deprecation warnings to all modules not previously prefixed with an underscore #620

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

agronholm
Copy link
Contributor

This was done to discourage anyone from importing wheel.

@agronholm
Copy link
Contributor Author

agronholm commented May 25, 2024

This can only be merged after a new setuptools release (v70.1 or v71.0) and when the necessary code has been merged to packaging and made it into a release.

…h an underscore

This was done to discourage anyone from importing `wheel`.
Copy link

codecov bot commented May 25, 2024

Codecov Report

Attention: Patch coverage is 74.05330% with 185 lines in your changes missing coverage. Please review.

Project coverage is 70.00%. Comparing base (1e00742) to head (c341c7f).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/wheel/_bdist_wheel.py 54.24% 140 Missing ⚠️
src/wheel/_macosx_libfile.py 92.81% 12 Missing ⚠️
src/wheel/_metadata.py 92.30% 7 Missing ⚠️
src/wheel/metadata.py 0.00% 6 Missing ⚠️
src/wheel/wheelfile.py 0.00% 5 Missing ⚠️
src/wheel/_wheelfile.py 96.66% 4 Missing ⚠️
src/wheel/_cli/__init__.py 25.00% 3 Missing ⚠️
src/wheel/bdist_wheel.py 0.00% 3 Missing ⚠️
src/wheel/macosx_libfile.py 0.00% 3 Missing ⚠️
src/wheel/__main__.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #620      +/-   ##
==========================================
- Coverage   71.03%   70.00%   -1.04%     
==========================================
  Files          13       17       +4     
  Lines        1084     1100      +16     
==========================================
  Hits          770      770              
- Misses        314      330      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@agronholm
Copy link
Contributor Author

This should actually be done when packaging contains all the necessary APIs so that nobody should have to import anything from wheel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant