Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: A vispy-based stage tracker #305

Open
wants to merge 43 commits into
base: main
Choose a base branch
from

Conversation

fdrgsp
Copy link
Collaborator

@fdrgsp fdrgsp commented Jun 25, 2024

In this very WIP PR I started thinking about a widget that tracks the stage movements and is able to record the positions (and move to new positions with double-click). The widget is named StageTracker. To see an example of usage run the stage_tracker.py example.

Screen.Recording.2024-06-24.at.8.03.00.PM.mov

NOTE: there is also a version named StageRecorder that is also adding the snapped images in the canvas. This requires more work on how to downsacale the images, etc... To see an example run the stage_recorder.py example.

@fdrgsp fdrgsp changed the title [WIP] feat: A Vispy-based stage tracker [WIP] feat: A vispy-based stage tracker Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 481 lines in your changes missing coverage. Please review.

Project coverage is 85.69%. Comparing base (95117e7) to head (5489b29).

Files Patch % Lines
src/pymmcore_widgets/_stage_recorder.py 0.00% 265 Missing ⚠️
src/pymmcore_widgets/_stage_tracker.py 0.00% 216 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
- Coverage   90.60%   85.69%   -4.91%     
==========================================
  Files          74       76       +2     
  Lines        8396     8877     +481     
==========================================
  Hits         7607     7607              
- Misses        789     1270     +481     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03
Copy link
Member

this is a pretty awesome feature @fdrgsp, and it would be good to get something like this in. For the sake of review, I think it would be helpful for me to get your thoughts on some high level things, such as what use cases this could serve, and also what the public API of the various objects should be. I know I can look at the code, but could you also comment here on the main objects and what they do? Does this build an image map of visited locations (hard to tell from your demo). Does it work with z positions? etc... basically, guide us a bit more through what your vision is here, in words

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants