-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: stackviewer v2 #293
feat: stackviewer v2 #293
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #293 +/- ##
==========================================
- Coverage 90.26% 83.94% -6.32%
==========================================
Files 76 87 +11
Lines 9583 10516 +933
==========================================
+ Hits 8650 8828 +178
- Misses 933 1688 +755 ☔ View full report in Codecov by Sentry. |
@wl-stepp, when you have a moment, it would be great if you could test this out. I apologize for redoing much of this, a I started to integrate it in a couple projects i found various things I wanted to abstract a little differently and ended up getting carried away (but it was very helpful having your viewer to begin with). The main thing (i think?) that isn't yet re-implemented here is spreading grid images across the canvas, but I'll add that back in shortly. Here are a few bullet points explaining what's different here:
I'm not sure what code you have that has begun to use (make sure to run |
Yes, that was my conclusion as well. I think that makes it another issue. I want to change the current EDA implementation that is running on the microscope to use the queue, so I will also think about this. |
See pymmcore-plus/pymmcore-plus#348 Which this pr is actually now using, and it's working with queues as well (see example mda_viewer_queue) |
…e-widgets into stack-viewer2
…e-widgets into stack-viewer2
closing in favor of #299, which branched off of this |
new stack viewer, inspired by @wl-stepp's awesome stack viewer, but generalized and abstracted a bit more (works for any array type, such as numpy, xarray), offers various color modes (grayscale, and composite), hopefully has a bit more robust indexing and event system, and abstracts out the vispy part, also providing a pygfx backend (and working on a pure qt backend as well)
needs some changes in superqt pyapp-kit/superqt#242
depends on pymmcore-plus/pymmcore-plus#348