-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update the CameraRoiWidget to handle multiple cameras #292
base: main
Are you sure you want to change the base?
Conversation
fdrgsp
commented
Apr 24, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #292 +/- ##
==========================================
- Coverage 90.85% 90.76% -0.10%
==========================================
Files 79 79
Lines 9102 9138 +36
==========================================
+ Hits 8270 8294 +24
- Misses 832 844 +12 ☔ View full report in Codecov by Sentry. |
hey @fdrgsp, is this still something we should get in? I haven't looked closely yet, but I'm wondering why support for two cameras would require a diff of 700+ lines. was this harder than it sounds? |
Hey @tlambert03 , I had to change the logic a bit to support the Multi Camera adapter so that each camera could be controlled individually. I also added a CameraInfo dataclass to store the info of each camera. I did it a while ago so I probably need to dig more into the code to exactly remember why the changes! |