Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport maintenance/2.17.x] Avoid consider-using-f-string on modulos with brackets in template … #8836

Merged
merged 4 commits into from
Jul 8, 2023
Merged

[Backport maintenance/2.17.x] Avoid consider-using-f-string on modulos with brackets in template … #8836

merged 4 commits into from
Jul 8, 2023

Conversation

jacobtylerwalls
Copy link
Member

Backport of #8720 to 2.17.x

@jacobtylerwalls jacobtylerwalls added this to the 2.17.5 milestone Jul 8, 2023
@Pierre-Sassoulas Pierre-Sassoulas added the False Positive 🦟 A message is emitted but nothing is wrong with the code label Jul 8, 2023
@Pierre-Sassoulas Pierre-Sassoulas force-pushed the backport-8720-to-maintenance/2.17.x branch from 04be23b to 17fbcfe Compare July 8, 2023 13:06
@jacobtylerwalls
Copy link
Member Author

To fix the merge conflict I regenerated the results but possibly with the wrong version of astroid, so I'll just reupdate from the pytest output on CI.

@jacobtylerwalls
Copy link
Member Author

Maybe the backport isn't worth it.

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Jul 8, 2023
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it did not work at first because you took the python 3.7 output. 3.8 was the only data used until very recently because it had more information (i.E. until we dumped python 3.7 entirely and simplified the functional tests helper).

@Pierre-Sassoulas Pierre-Sassoulas enabled auto-merge (squash) July 8, 2023 19:03
@jacobtylerwalls jacobtylerwalls merged commit 1928589 into pylint-dev:maintenance/2.17.x Jul 8, 2023
20 checks passed
@jacobtylerwalls jacobtylerwalls deleted the backport-8720-to-maintenance/2.17.x branch July 8, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Milestone
2.17.5
Development

Successfully merging this pull request may close these issues.
3 participants
@jacobtylerwalls @Pierre-Sassoulas @progval