Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ClientSession.prepare_inat_request() to return a Request instead of PreparedRequest #489

Merged
merged 1 commit into from
May 28, 2023

Conversation

JWCook
Copy link
Member

@JWCook JWCook commented May 28, 2023

Related to #217. This is an incremental step toward making the process a bit less complicated between calling an iNatClient method and making the actual HTTP request. This change allows a request object to be modified after processing all custom params, but before sending the request.

@JWCook JWCook added the refactoring (Re)factoring, cleanup, tech debt, etc. label May 28, 2023
@JWCook JWCook added this to the v0.19 milestone May 28, 2023
@JWCook JWCook merged commit c5c14ec into main May 28, 2023
@JWCook JWCook deleted the refactor-client-session branch May 28, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring (Re)factoring, cleanup, tech debt, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant