Avoid the use of stride tricks to make code more readable #89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Admittedly this is a style issue, but I feel like stridetricks isn't very useful in this particular case and it somewhat destroys readability for me.
While the reshaping is cute, I honestly don't think it helps much with the python overhead.
I hit this code in trying to implment frustum culling for my application (though I still haven't succeeded in getting a performance improvement).
Let me know what you think.
I think there is also some complexity in the code due to an attempt at making it generaizable to beyond a single "aabb" object.
However, I didn't see any tests for this, and so my presumption is that this is problem and likely the cause of much of the original code compelxity.