Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent qthrottled and qdebounced from holding strong references with bound methods #247

Merged
merged 5 commits into from
Jun 3, 2024

add test for warning

4badc90
Select commit
Loading
Failed to load commit list.
Merged

fix: prevent qthrottled and qdebounced from holding strong references with bound methods #247

add test for warning
4badc90
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 3, 2024 in 0s

87.14% (+0.06%) compared to 7b1aefd

View this Pull Request on Codecov

87.14% (+0.06%) compared to 7b1aefd

Details

Codecov Report

Attention: Patch coverage is 97.43590% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 87.14%. Comparing base (7b1aefd) to head (4badc90).

Files Patch % Lines
src/superqt/utils/_throttler.py 97.43% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #247      +/-   ##
==========================================
+ Coverage   87.07%   87.14%   +0.06%     
==========================================
  Files          46       46              
  Lines        3397     3423      +26     
==========================================
+ Hits         2958     2983      +25     
- Misses        439      440       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.