Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use scientific notation for big values inl labeled slider #226

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Czaki
Copy link
Contributor

@Czaki Czaki commented Dec 15, 2023

Closes #224

Use QLabel instead of QDoubleSpinBox for custom representation of big/small values.

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: Patch coverage is 85.71429% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 87.18%. Comparing base (0396d46) to head (5d87bc5).

Files Patch % Lines
src/superqt/sliders/_labeled.py 85.71% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
- Coverage   87.30%   87.18%   -0.13%     
==========================================
  Files          46       46              
  Lines        3332     3371      +39     
==========================================
+ Hits         2909     2939      +30     
- Misses        423      432       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03
Copy link
Member

basic idea looks good. lemme know when ready for a full review. How do you plan to manage when it switches into scientific notation?

@Czaki
Copy link
Contributor Author

Czaki commented Dec 17, 2023

Currently, it depends on str(float), as for big values, on my machine it uses scientific notation. I need to check how universal it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Use scientific notification for Labeled sliders values for big/small values
2 participants