fix: fix callback of throttled/debounced decorated functions with mismatched args #184
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
similar to #183, this fixes calling a qdebounced/qthrottled function with too many arguments
I had to do it manually here (meaning pass
func(*args[:max_args])
), because of a bug in pyside that prevents proper inspection of callable objects:https://bugreports.qt.io/browse/PYSIDE-2423
This PR also changes the decorator pattern to return an instance of ThrottledCallable (whereas before it just returned an object that implemented the protocol). I think it makes for a much clearer read