Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test python 3.12 #181

Merged
merged 5 commits into from
Oct 8, 2023
Merged

ci: test python 3.12 #181

merged 5 commits into from
Oct 8, 2023

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Aug 13, 2023

Summary by CodeRabbit

  • New Feature: Added support for Python 3.12-dev on the Ubuntu platform with the PyQT6 backend in our CI/CD pipeline. This enhancement will ensure our application's compatibility and performance with the latest Python version and Qt backend, providing a more robust and future-proof user experience.

@tlambert03 tlambert03 closed this Sep 12, 2023
@tlambert03 tlambert03 reopened this Sep 12, 2023
@coderabbitai
Copy link

coderabbitai bot commented Sep 23, 2023

Walkthrough

The proposed changes introduce a new job configuration for the continuous integration pipeline. This addition targets Python 3.12-dev on Ubuntu with the PyQT6 backend, expanding the test coverage to include this environment alongside the existing Windows/PySide6 and Ubuntu/legacy Qt configurations.

Changes

File Summary
.github/workflows/test_and_deploy.yml Added a new CI job for Python 3.12-dev on Ubuntu with PyQT6 backend.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • Mention @coderabbitai in any review comment for bot assistance.
  • Note: Review comments are made on code diffs or files, not on the PR overview.

Pause Incremental Reviews

  • Insert @coderabbitai: ignore in the PR description to halt the bot's ongoing reviews. Remove the line to resume.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between 409d19e and 8222b35.
Files selected for processing (1)
  • .github/workflows/test_and_deploy.yml (1 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/test_and_deploy.yml

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (409d19e) 87.30% compared to head (db1f86b) 87.38%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
+ Coverage   87.30%   87.38%   +0.08%     
==========================================
  Files          45       45              
  Lines        3324     3346      +22     
==========================================
+ Hits         2902     2924      +22     
  Misses        422      422              

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 merged commit 65a4a6e into pyapp-kit:main Oct 8, 2023
44 checks passed
@tlambert03 tlambert03 deleted the py312 branch October 8, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant